eigrpd: improve validation and error-handling in tlv parsing (backport #21316) - #21365
Closed
mergify[bot] wants to merge 2 commits into
Closed
eigrpd: improve validation and error-handling in tlv parsing (backport #21316)#21365mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
added 2 commits
March 25, 2026 22:24
Harden validation of lengths before accessing packets; detect and handle invalid INT TLVs where they're created. Reported-by: Haruto Kimura (Stella) <harutokimura0608@gmail.com> Signed-off-by: Mark Stapp <mjs@cisco.com> (cherry picked from commit 284c966) # Conflicts: # eigrpd/eigrp_packet.c # eigrpd/eigrp_update.c
Try to skip unknown TLVs in places where we don't process all types. Reported-by: Haruto Kimura (Stella) <harutokimura0608@gmail.com> Signed-off-by: Mark Stapp <mjs@cisco.com> (cherry picked from commit d05029d)
Author
|
Cherry-pick of 284c966 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Target branch is not in the allowed branches list. |
Contributor
|
looks like auto-backports aren't working; closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more length validation before accessing packet data; add error-detection in several paths; try to skip unknown TLV types in more cases.
This is an automatic backport of pull request #21316 done by [Mergify](https://mergify.com).