[GroovyDan]

Issue #, if available:

Description of changes:

This change is to allow easier testing of data classes by adding an eq function to the base DictWrapper class. This new function will check the equality of the data contained in the object opposed to the memory location.

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

• Migration process documented
• Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[heitorlessa]

hey @GroovyDan thanks a lot for taking the time in making your first contribution, we appreciate it very much :)

LGTM at first glance and can see how it can make tests easier (it'd be great to have one test updated to cover it too). However, I need to triple check the side effects of not having __hash__, as this will make the class not hashable too.

what do you think @michaelbrewer?

[Nr18]

@GroovyDan nice addition indeed, it did raise a question while looking at it though. (Next to the missing tests that @heitorlessa mentioned)

[heitorlessa]

One small change required as per @Nr18 pointed out

I've also double checked about equality and hash theory. __hash__ won't be necessary because Dicts are not hashable, so DictWrapper not being hashable with __eq__ isn't an issue in this case.

[heitorlessa]

Thanks a lot for making the change @GroovyDan - Merging this now.