[tonnico]

Issue number: #4113

Summary

Changes

Overload functions with default_value when it becomes not Optional anymore.

User experience

Ensure return type without casting.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[rubenfonseca]

@wurstnase it seems some tests are failing, can you please look at them?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (e14e768) to head (8692b40).
Report is 299 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4114      +/-   ##
===========================================
- Coverage    96.38%   96.25%   -0.13%     
===========================================
  Files          214      216       +2     
  Lines        10030    10394     +364     
  Branches      1846     1921      +75     
===========================================
+ Hits          9667    10005     +338     
- Misses         259      275      +16     
- Partials       104      114      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rubenfonseca]

This is amazing work, thank you VERY much!! I left some small nit picks here and there that should be easy to fix. I loved to see the test changing at the end to remove the type ignore!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
27.8% Duplication on New Code

See analysis details on SonarCloud

[rubenfonseca]

Stellar work, thank you so much for spending time improving the experience here. Seriously, thank you!