frontend: Fix removal of missing plugins

Updates the plugin manager window rows to use a local copy of
ModuleInfo.

Passing around a pointer to the actual entry within the modules_ vector
felt like a sensible optimization for updating the enabled state of
entries. However when deleting entries from the Missing category it
means pointers to anything after the deleted entry become incorrect or
invalidated.

Author: Warchamp7

frontend/plugin-manager/InstalledPluginRow.cpp

@@ -27,12 +27,12 @@ constexpr std::string_view kLegacyPluginInfoLink{"https://obsproject.com/go/lega
 namespace OBS {
 InstalledPluginRow::InstalledPluginRow(QWidget *parent, const PluginManagerWindow::Entry &entry) : idian::Row(parent)
 {
-	OBS::ModuleInfo *metadata = entry.module;
+	const OBS::ModuleInfo &metadata = entry.module;
 
 	setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Preferred);
 	QString name = entry.name;
 
-	QString version = metadata && !metadata->version.empty() ? metadata->version.c_str() : "";
+	QString version = !metadata.version.empty() ? metadata.version.c_str() : "";
 
 	auto *moduleText = new QWidget{this};
 	moduleText->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Preferred);
@@ -49,7 +49,7 @@ InstalledPluginRow::InstalledPluginRow(QWidget *parent, const PluginManagerWindo
 	nameLabel->setSizePolicy(QSizePolicy::Maximum, QSizePolicy::Minimum);
 	nameLabel->setIndent(0);
 	idian::Utils::addClass(nameLabel, "title");
-	if (metadata && !metadata->enabledAtLaunch) {
+	if (!metadata.enabledAtLaunch) {
 		idian::Utils::addClass(nameLabel, "text-muted");
 	}
 	headerLayout->addWidget(nameLabel);
@@ -118,7 +118,7 @@ InstalledPluginRow::InstalledPluginRow(QWidget *parent, const PluginManagerWindo
 			detailsLayout->addWidget(legacyNotice);
 		}
 
-		if (metadata && !metadata->enabledAtLaunch) {
+		if (!metadata.enabledAtLaunch) {
 			statusChip = new InfoChip{QTStr("PluginManager.Status.Disabled"), moduleText};
 			idian::Utils::addClass(statusChip, "bg-info");
 			idian::Utils::addClass(statusChip, "text-muted");
@@ -129,17 +129,14 @@ InstalledPluginRow::InstalledPluginRow(QWidget *parent, const PluginManagerWindo
 		headerLayout->addWidget(statusChip);
 	}
 
-	if (metadata) {
+	if (entry.hasLoadedBefore) {
 		auto toggleSwitch = new idian::ToggleSwitch(this);
-		toggleSwitch->setChecked(metadata->enabled);
+		toggleSwitch->setChecked(metadata.enabled);
 		addWidget(toggleSwitch);
 		toggleSwitch->setAccessibleDescription(QTStr("PluginManager.Button.Enable").arg(name));
 
-		connect(toggleSwitch, &idian::ToggleSwitch::toggled, this, [this, metadata](bool checked) {
-			metadata->enabled = checked;
-
-			emit toggleChanged();
-		});
+		connect(toggleSwitch, &idian::ToggleSwitch::toggled, this,
+			[this](bool checked) { emit toggleChanged(checked); });
 	}
 
 	if (entry.category == PluginManagerWindow::Category::Missing) {

frontend/plugin-manager/InstalledPluginRow.hpp

@@ -30,7 +30,7 @@ class InstalledPluginRow : public idian::Row {
 	InstalledPluginRow(QWidget *parent, const PluginManagerWindow::Entry &entry);
 
 signals:
-	void toggleChanged();
+	void toggleChanged(bool enabled);
 	void trashClicked();
 
 private:

frontend/plugin-manager/PluginManagerWindow.cpp

@@ -177,18 +177,24 @@ void PluginManagerWindow::setupInstalledPage(std::vector<std::string> failedModu
 							      : metadata.module_name.c_str();
 		QString version = !metadata.version.empty() ? metadata.version.c_str() : "";
 
-		Entry newEntry{&metadata, name, category, isLegacyModule};
+		Entry newEntry{metadata, name, category, isLegacyModule};
 		installedPluginEntries.push_back(newEntry);
 	}
 
 	for (const std::string &moduleName : failedModules) {
 		// This failed module is not in the plugin manager cache which means it has never been loaded successfully.
 		// Create a dummy visual entry for it.
+		OBS::ModuleInfo dummyModule;
 		QString name = QString::fromStdString(moduleName.data());
 		Category category{Category::Error};
 		bool isLegacy{false};
+		bool hasLoadedBefore{false};
 
-		Entry newEntry{nullptr, name, category, isLegacy};
+		dummyModule.module_name = moduleName;
+		dummyModule.enabled = false;
+		dummyModule.enabledAtLaunch = false;
+
+		Entry newEntry{dummyModule, name, category, isLegacy, hasLoadedBefore};
 		installedPluginEntries.push_back(newEntry);
 	}
 
@@ -217,25 +223,34 @@ void PluginManagerWindow::setupInstalledPage(std::vector<std::string> failedModu
 
 		if (entry.category == Category::Installed) {
 			installedPluginList->addRow(newRow);
-
-			connect(newRow, &InstalledPluginRow::toggleChanged, this,
-				[this]() { ui->manageRestartLabel->setVisible(isEnabledPluginsChanged()); });
-
 		} else if (entry.category == Category::Error) {
 			errorPluginList->addRow(newRow);
 		} else if (entry.category == Category::Missing) {
 			missingPluginList->addRow(newRow);
 
-			connect(newRow, &InstalledPluginRow::trashClicked, this, [this, newRow, entry]() {
-				auto it = std::find_if(modules_.begin(), modules_.end(), [&entry](const auto &module) {
-					return &module == entry.module;
-				});
+			connect(newRow, &InstalledPluginRow::trashClicked, this, [this, entry]() {
+				auto it = std::find_if(modules_.begin(), modules_.end(),
+						       [&entry](const ModuleInfo &module) {
+							       return module.module_name == entry.module.module_name;
+						       });
 
 				if (it != modules_.end()) {
 					modules_.erase(it);
 				}
 			});
 		}
+
+		connect(newRow, &InstalledPluginRow::toggleChanged, this, [this, entry](bool enabled) {
+			auto it = std::find_if(modules_.begin(), modules_.end(), [&entry](const ModuleInfo &module) {
+				return module.module_name == entry.module.module_name;
+			});
+
+			if (it != modules_.end()) {
+				it->enabled = enabled;
+			}
+
+			ui->manageRestartLabel->setVisible(isEnabledPluginsChanged());
+		});
 	}
 
 	setTabOrder(previousRow, ui->buttonBox);
@@ -293,7 +308,7 @@ bool PluginManagerWindow::isEnabledPluginsChanged()
 	bool result = false;
 	for (auto &entry : installedPluginEntries) {
 		// Only prompt for restart when a loadable plugin entry changed.
-		if (entry.category == Category::Installed && entry.module->enabledAtLaunch != entry.module->enabled) {
+		if (entry.category == Category::Installed && entry.module.enabledAtLaunch != entry.module.enabled) {
 			result = true;
 			break;
 		}

frontend/plugin-manager/PluginManagerWindow.hpp

@@ -34,10 +34,11 @@ class PluginManagerWindow : public QDialog {
 	enum class Category { Invalid = 0, Installed, Error, Missing };
 
 	struct Entry {
-		OBS::ModuleInfo *module{nullptr};
+		OBS::ModuleInfo module;
 		QString name{};
 		Category category{Category::Invalid};
 		bool isLegacy{false};
+		bool hasLoadedBefore{true};
 	};
 
 	enum class Page { Installed };