Skip to content

Implement WriteDelimitedTo(BufferWriter<byte>) - #21325

Closed
verdie-g wants to merge 4 commits into
protocolbuffers:mainfrom
verdie-g:write-delimited-buffer-writer
Closed

Implement WriteDelimitedTo(BufferWriter<byte>)#21325
verdie-g wants to merge 4 commits into
protocolbuffers:mainfrom
verdie-g:write-delimited-buffer-writer

Conversation

@verdie-g

@verdie-g verdie-g commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #21300

I could not find tests MessageExtensions so I added a new test file.

@verdie-g
verdie-g requested a review from a team as a code owner April 17, 2025 03:18
@verdie-g
verdie-g requested review from jskeet and removed request for a team April 17, 2025 03:18
@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 18, 2025
@github-actions github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 18, 2025
@zhangskz
zhangskz requested a review from amanda-tarafa April 18, 2025 18:30
@zhangskz zhangskz added the c# label Apr 18, 2025
@verdie-g

verdie-g commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

@amanda-tarafa could you have a look at this PR please 🙏

@aohotnik

aohotnik commented Jun 23, 2025

Copy link
Copy Markdown

Can we get this pushed further somehow? Library leaves no public surface for workaround. Forcing to write our own length when proper api is just one internal call away is unnecessarily defensive library design.

@verdie-g

verdie-g commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

@jskeet I understand you don't have much time to dedicate to protobuf these days but I'm not able to get a response on this small PR so following the Contributing Process I'd appreciate your help here 🙏

@jskeet
jskeet removed their request for review July 3, 2025 15:34
@verdie-g verdie-g mentioned this pull request Sep 5, 2025
Closed
@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions Bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Oct 2, 2025
@verdie-g

verdie-g commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

Still waiting for a reviewer.

@github-actions github-actions Bot added untriaged auto added to all issues by default when created. and removed inactive Denotes the issue/PR has not seen activity in the last 90 days. labels Oct 3, 2025
@googleberg

googleberg commented Oct 3, 2025

Copy link
Copy Markdown
Member

C# team is still underwater.

@googleberg googleberg removed the untriaged auto added to all issues by default when created. label Oct 3, 2025
@amanda-tarafa amanda-tarafa removed their assignment Oct 3, 2025
@amanda-tarafa
amanda-tarafa removed their request for review October 3, 2025 22:32
@amanda-tarafa

amanda-tarafa commented Oct 3, 2025

Copy link
Copy Markdown

I'm sorry, but my focus is elsewhere at the moment.

@bellspice
bellspice requested a review from esrauchg October 28, 2025 17:41
esrauchg
esrauchg requested changes Oct 28, 2025
View reviewed changes
Comment thread csharp/src/Google.Protobuf.Test/MessageExtensionsTest.cs Resolved
Comment thread csharp/src/Google.Protobuf/MessageExtensions.cs Resolved
@verdie-g
verdie-g requested a review from esrauchg October 31, 2025 10:29
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 31, 2025
@github-actions github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 31, 2025
esrauchg
esrauchg approved these changes Oct 31, 2025
View reviewed changes

@esrauchg esrauchg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Comment thread csharp/src/Google.Protobuf.Test/MessageExtensionsTest.cs Resolved
@verdie-g

verdie-g commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@esrauchg anything missing to get this merged?

@verdie-g
verdie-g requested a review from esrauchg November 29, 2025 16:05
@esrauchg

esrauchg commented Jan 28, 2026

Copy link
Copy Markdown
Member

Sorry, this got hung up on CI failures. I kicked the import and it should resolve now.

Since we've already cut our first Q1 release's branch for the RC, we would plan to only release this with Q2 release.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esrauchg esrauchg esrauchg approved these changes

Assignees

No one assigned

Labels

c#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WriteDelimitedTo(IBufferWriter<byte>)

6 participants

@verdie-g @aohotnik @googleberg @amanda-tarafa @esrauchg @zhangskz