Skip to content

Migrate proto_descriptor_set - #23369

Closed
SpencerC wants to merge 2 commits into
protocolbuffers:mainfrom
SpencerC:proto_descriptor_set
Closed

Migrate proto_descriptor_set#23369
SpencerC wants to merge 2 commits into
protocolbuffers:mainfrom
SpencerC:proto_descriptor_set

Conversation

@SpencerC

@SpencerC SpencerC commented Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is just a straightforward copy of https://github.com/bazelbuild/rules_proto/blob/main/proto/private/rules/proto_descriptor_set.bzl with the related tooling and test files. The only modifications are:

  • Changed paths to match the organization of this repo
  • Included constants directly in the test file instead of a separate header in a separate directory.

Closes #19647

turmanticant
turmanticant reviewed Sep 4, 2025
View reviewed changes

@turmanticant turmanticant left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this get added 😁

Comment thread bazel/BUILD.bazel Resolved
@SpencerC
SpencerC force-pushed the proto_descriptor_set branch from 9d9bd66 to 2b99f07 Compare September 15, 2025 17:06
@neilconway

neilconway commented Sep 24, 2025

Copy link
Copy Markdown

+1 -- we also use this, and the lack of proto_descriptor_set makes it impossible to migrate from rules_proto to the built-in protobuf rules.

@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2025
@github-actions github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2025
@SpencerC
SpencerC force-pushed the proto_descriptor_set branch from 2b99f07 to 8016162 Compare September 25, 2025 01:31
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2025
@github-actions github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2025
mkruskal-google
mkruskal-google reviewed Sep 25, 2025
View reviewed changes
Comment thread bazel/private/file_concat/main.cc Resolved
mkruskal-google
mkruskal-google reviewed Sep 25, 2025
View reviewed changes
Comment thread tools/file_concat/BUILD.bazel Resolved
@mkruskal-google mkruskal-google added 🅰️ safe for tests Mark a commit as safe to run presubmits over bazel and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Sep 25, 2025
@github-actions github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2025
copybara-service Bot pushed a commit that referenced this pull request Oct 1, 2025