Implementation of try_from_{nanos_u128,mins,hours,days,weeks}

[Zorbatron]

Implements the methods discussed in the related ACP.

impl Duration {
    pub const fn try_from_nanos_u128(nanos: u128) -> Result<Duration, DurationConversionError>;
    pub const fn try_from_weeks(weeks: u64) -> Result<Duration, DurationConversionError>;
    pub const fn try_from_days(days: u64) -> Result<Duration, DurationConversionError>;
    pub const fn try_from_hours(hours: u64) -> Result<Duration, DurationConversionError>;
    pub const fn try_from_mins(mins: u64) -> Result<Duration, DurationConversionError>;
}

ACP: rust-lang/libs-team#749
Tracking issue: #153678

[rustbot]

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @scottmcm, libs
• @scottmcm, libs expanded to 8 candidates
• Random selection from Mark-Simulacrum, scottmcm

[Zorbatron]

@scottmcm, sorry for the ping if I'm missing something for this PR to be reviewed, but it's been over a month. Are you available to look this over?

[teor2345]

The code here looks good, I have a question about the stability of the error and display impls. (Probably for the libs-api team to answer.)

View changes since this review

[teor2345]

I think removing the stability of the Error and Display impls from TryFromFloatSecsError is a breaking change?
https://doc.rust-lang.org/std/time/struct.TryFromFloatSecsError.html#impl-Error-for-TryFromFloatSecsError

Maybe it's worth asking if DurationConversionError and its trait impls should be stabilised instead?
rust-lang/libs-team#749 (comment)

Here's the context from the meeting notes approving the ACP:
https://hackmd.io/rGWrzOppS8-ehldMMjWwKQ#new-change-proposal-rusttflibs749-ACP-Add-non-panicking-versions-of-Durationfrom_nanos_u128minshoursdaysweeks

Suddenly not being able to print the return type of the stable try_from_secs_f64() method seems surprising for users. So does having to name it using a stable alias that doesn't appear in the method docs.

[scottmcm]

Nominating the discuss the questions from @teor2345 above.

r? joshtriplett

[rustbot]

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

[joshtriplett]

Fixed the signature of try_from_nanos_u128 in the OP to match the correct signature in the PR.

[nia-e]

This was discussed in today's @rust-lang/libs-api meeting; the idea we came up with was to (for now) keep TryFromFloatSecsError and make DurationConversionError an unstable alias to it. We're not 100% on whether unstable aliases behave properly, so if that doesn't work we can FCP an instantly-stable DurationConversionError and make TryFromFloatSecsError an alias to it instead

[Zorbatron]

... keep TryFromFloatSecsError and make DurationConversionError an unstable alias to it.

Just to confirm, this would mean adding the {Nanoseconds,Weeks,Days,Hours,Minutes}Overflow variants to TryFromFloatSecsError instead of DurationConversionErrorKind (for now)?

[the8472]

The kind is a private type so that change shouldn't change anything user-visible.

[Zorbatron]

Or, keep DurationConversionErrorKind but change

pub struct TryFromFloatSecsError {
    kind: TryFromFloatSecsErrorKind,
}

to

pub struct TryFromFloatSecsError {
    kind: DurationConversionErrorKind,
}

[Zorbatron]

Oop, I didn't see your comment the8472.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Zorbatron]

@teor2345 ping? I kind of forgot about this after addressing your review.

[teor2345]

This looks fine to me, but I'm not a final approver here.

View changes since this review

[Zorbatron]

@joshtriplett is this PR good now?