Skip to content

feat: nop display name - #18606

Merged
ChrisAmora merged 4 commits into
developfrom
feat/bump-jd-orchestrator-protos
Jul 15, 2025
Merged

ChrisAmora merged 4 commits into
developfrom
feat/bump-jd-orchestrator-protos

Conversation

@ChrisAmora

@ChrisAmora ChrisAmora commented Jul 14, 2025 •

Copy link
Copy Markdown
Contributor

Allow NOPS to specify a display name for Job Distributor via config.

https://smartcontract-it.atlassian.net/browse/DX-1362

Comment thread core/config/docs/core.toml Resolved
Comment thread core/config/docs/core.toml Resolved
Comment thread core/config/job-distributor.go Resolved
Comment thread core/config/docs/core.toml Outdated
# Job Distributor stores the configuration for Job Distributor
[JobDistributor]
# NopFriendlyName is a friendly name set by the NOP to be shown in Job Distributor.
NopFriendlyName = "MyDON-Production-01" # Example

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bad example. We don't want NOPs to put "DON" anywhere here. "Production" also doesn't make sense, every node run by NOPs is production :)

Maybe
NopDisplayName = "cre-workflow-1-chainlinklabs"

(this is assuming that we want to include both the name of the NOP as well as the node. Maybe it's better to split those two...?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop the Nop prefix too.

Suggested change
NopFriendlyName = "MyDON-Production-01" # Example
DisplayName = "cre-workflow-1-chainlinklabs" # Example

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DisplayName seems better indeed, tell me what you think @cedric-cordenier @jmank88 @bolekk
8f97554

Comment thread core/config/job-distributor.go Resolved
Comment thread docs/CONFIG.md Resolved
@ChrisAmora ChrisAmora changed the title feat: nop friendly name feat: nop display name Jul 15, 2025
Comment thread core/config/docs/core.toml Outdated
# Job Distributor stores the configuration for Job Distributor
[JobDistributor]
# DisplayName is a friendly, fully qualified name set by the NOP to clearly identify the node in Job Distributor.
# It should uniquely and unambiguously represent the node when communicating with Job Distributor maintainers or operators

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • vice-versa -- i.e. we can use this when communicating with NOPs as well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants