Repository navigation
feat(system-test/cre): link owner to v2 wf registry - #19346
Conversation
MStreet3
changed the title
| // Convert payload fields into Solidity-compatible data types and concatenate them in the expected order. | ||
| // Use the same hashing algorithm as the Solidity contract (keccak256) to hash the concatenated data. | ||
| // Finally, follow the EIP-191 standard to create the final hash for signing. | ||
| func PreparePayloadForSigning(payload OwnershipProofSignaturePayload) ([]byte, error) { |
There was a problem hiding this comment.
is there a library or util in chainlink-common we can use instead of maintaining this?
There was a problem hiding this comment.
it will live in the CRE CLI @shileiwill @anirudhwarrier is there a plan to put this in a shared library?
There was a problem hiding this comment.
+1 for putting this somewhere shared since it's fairly involved logic
| donID := uint32(1) | ||
| donFamily := "A" | ||
|
|
||
| tickChan := make(chan time.Time) |
There was a problem hiding this comment.
just use the default ticker created by the syncer
| var filename string | ||
| if tb == nil { | ||
| filename = fmt.Sprintf("%s_%d.log", uuid.NewString(), time.Now().UnixNano()) | ||
| filename = fmt.Sprintf("%s_%s.log", time.Now().Format(timeLayout), uuid.NewString()) |
There was a problem hiding this comment.
You seem to have reversed the order from uuid_time to time_uuid. Here and below.
Is that intentional?
There was a problem hiding this comment.
done for readability. only humans look for these logs atm for manual debugging.
| if _, exists := nopMap[nopName]; !exists { | ||
| nopMap[nopName] = capabilities_registry_v2.CapabilitiesRegistryNodeOperator{ | ||
| Admin: common.Address{}, // Will be set by the deployment framework | ||
| Admin: common.HexToAddress(fmt.Sprintf("0xaadd00000000000000000000000000000000000%d", i+1)), |
There was a problem hiding this comment.
Would't this break when i+1 = 10?
I assume 10 is 2 digits, that increases the address string length, which might be an invalid address.
|
This PR links the workflow owner to the V2 workflow registry and corrects a few configuration bugs for using both V2 registries e2e. Includes a fix to the V2 workflow registry syncer that was blocking syncing.
supercedes #19362
Requires
Supports