Repository navigation
Conversation
prashantkumar1982
left a comment
prashantkumar1982
left a comment
There was a problem hiding this comment.
Could you please wait before my other PR #19543 is merged in?
Reason is because the e2e tests that test the auth flow including this code is only enabled in that PR.
There was a problem hiding this comment.
Please look at my PR: #19543
I've changed the methods in this file, and moved them to another place, since it was also needed by the e2e tests.
The Digest method was previously non-deterministic.
| } | ||
| w.allowListedMu.Lock() | ||
| w.allowListedRequests = allowListedRequests | ||
| // Prune expired requests |
There was a problem hiding this comment.
Does the onchain contract always keep all requests? It doesn't prune expired ones ever?
Asking because if it prunes then our lastSeenAllowlistedRequestsCount value wouldn't be correct.
There was a problem hiding this comment.
Onchain never prunes - the total is only increasing.
…equest-authorizer-endpoint-in-workflow-registry # Conflicts: # core/capabilities/vault/request_authorizer.go # core/capabilities/vault/request_authorizer_test.go # core/services/workflows/syncer/v2/workflow_registry.go
| GetWorkflowsByDONMethodName = "getWorkflowListByDON" | ||
| GetAllowlistedRequestsMethodName = "getAllowlistedRequests" | ||
| GetWorkflowsByDONMethodName = "getWorkflowListByDON" | ||
| GetAllowlistedRequestsMethodName = "getAllowlistedRequests" |
There was a problem hiding this comment.
As this is no longer used, it can be deleted now right?
|
No description provided.