Skip to content

Update chainlink ccip refs - remove refs to latest - #21550

Merged
RensR merged 6 commits into
developfrom
update-chainlink-ccip-refs
Mar 18, 2026
Merged

RensR merged 6 commits into
developfrom
update-chainlink-ccip-refs

Conversation

@RensR

@RensR RensR commented Mar 17, 2026 •

Copy link
Copy Markdown
Contributor

This PR removes all references to github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/latest and replaces them with versioned references. This is not only a lot safer, it also unblocks us moving the CCIP v2 code into latest without breaking things

@github-actions

github-actions Bot commented Mar 17, 2026 •

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

github-actions Bot commented Mar 17, 2026 •

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop


lpOpts := logpoller.Opts{
PollPeriod: time.Millisecond,
PollPeriod: 100 * time.Millisecond,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is flakey, this should reduce the odds significantly while the true fix is developed

@trunk-io

trunk-io Bot commented Mar 17, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@cl-sonarqube-production

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW (broad but mostly mechanical import-path updates; small test timing tweaks; one small script-output change)

This PR removes references to .../generated/latest Chainlink CCIP go-bindings and replaces them with explicit, version-locked import paths to prevent accidental breaking changes when latest moves.

Changes:

  • Replaced generated/latest go-bindings imports across integration tests, deployment tooling, and CCIP testhelpers with explicit vX_Y_Z package paths.
  • Adjusted polling intervals in CCIP reader smoke tests (Eventually cadence + logpoller PollPeriod) to reduce flakiness/CPU churn.
  • Updated the CCIP revert-reason handler to use versioned bindings and expanded the ABI set used for decoding.

Scrupulous human review recommended for:

  • core/scripts/ccip/revert-reason/handler/reason.go (diagnostic output/decoding behavior and printing changes)
  • integration-tests/smoke/ccip/ccip_reader_test.go (timing/polling changes that can affect test stability and runtime)

Suggested reviewers (per CODEOWNERS):

  • Integration tests: @smartcontractkit/ccip-offchain, @smartcontractkit/ccip, @smartcontractkit/core
  • Deployment/CCIP tooling: @smartcontractkit/ccip-tooling, @smartcontractkit/operations-platform, @smartcontractkit/core
  • OCR2 CCIP plugin testhelpers: @smartcontractkit/ccip
  • Changesets: @smartcontractkit/foundations, @smartcontractkit/core

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
integration-tests/smoke/ccip/ccip_reader_test.go Tweaks Eventually + logpoller polling intervals in CCIP reader smoke tests.
integration-tests/ccip-tests/smoke/ccip_test.go Updates CCIP token_pool binding import to a versioned package.
integration-tests/ccip-tests/contracts/contract_models.go Replaces several latest go-bindings with versioned equivalents.
integration-tests/ccip-tests/contracts/contract_deployer.go Replaces several latest go-bindings with versioned equivalents.
integration-tests/ccip-tests/actions/ccip_helpers.go Replaces latest go-bindings with versioned equivalents.
deployment/ccip/shared/stateview/state.go Replaces latest stateview bindings with v1_6_0 equivalents.
deployment/ccip/shared/stateview/evm/state.go Replaces latest stateview bindings with v1_6_0 equivalents.
deployment/ccip/shared/bindings/fast_transfer_token_pool_wrapper.go Pins fast transfer token pool binding to v1_6_0.
deployment/ccip/changeset/v1_6_2/cs_deploy_usdc_token_pools_test.go Pins USDC mock bindings to v1_6_0.
deployment/ccip/changeset/v1_6_2/cs_deploy_usdc_token_pools.go Pins USDC mock messenger binding to v1_6_0.
deployment/ccip/changeset/v1_6_2/cs_deploy_cctp_message_transmitter_proxy_test.go Pins USDC mock bindings to v1_6_0.
deployment/ccip/changeset/v1_6_2/cs_configure_usdc_token_pool_test.go Pins USDC mock bindings to v1_6_0.
deployment/ccip/changeset/v1_6_2/cs_configure_cctp_message_transmitter_proxy_test.go Pins USDC mock bindings to v1_6_0.
deployment/ccip/changeset/v1_6/cs_ccip_home.go Pins don_id_claimer binding to v1_6_0.
deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e_test.go Pins don_id_claimer binding to v1_6_0.
deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go Pins don_id_claimer binding to v1_6_0.
deployment/ccip/changeset/v1_5_1/cs_deploy_usdc_token_pools_test.go Pins USDC mock bindings to v1_6_0.
deployment/ccip/changeset/v1_5_1/cs_deploy_usdc_token_pools.go Pins USDC mock messenger binding to v1_6_0.
deployment/ccip/changeset/v1_5_1/cs_deploy_token_pools.go Pins fast transfer token pool binding to v1_6_0.
deployment/ccip/changeset/testhelpers/test_helpers_solana_v0_1_0.go Removes latest offramp import and reorders imports around pinned versions.
deployment/ccip/changeset/cs_prerequisites.go Replaces latest bindings with pinned v1_6_0 equivalents.
core/services/ocr2/plugins/ccip/testhelpers/testhelpers_1_4_0/ccip_contracts_1_4_0.go Replaces latest maybe_revert_message_receiver with v1_6_0.
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go Replaces latest maybe_revert_message_receiver with v1_6_0.
core/scripts/ccip/revert-reason/handler/reason.go Pins bindings; adds PriceRegistry ABI; adjusts TokenHandlingError printing.
core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go Pins usdc_reader_tester binding to v1_6_0.
.changeset/fresh-cakes-hit.md Adds a changeset entry for the import-path pinning change.

Comment thread .changeset/fresh-cakes-hit.md Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants