Repository navigation
Fix column header scrolling with the page - #11458
Merged
Merged
Conversation
Regression from aa22b38
Gargron
force-pushed
the
fix-columns-header-scroll
branch
from
August 1, 2019 08:45
0cb3a1b to
d6c607e
Compare
ykzts
approved these changes
Aug 1, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Regression from aa22b38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11396
Regression from aa22b38
The
position: stickyproperty only works for certain DOM structures so I had to modify theColumnHeadercomponent to render through a portal in theTabsBarcomponent in single-column mode. On the upside, the tabs bar and the column header now work just like before the whole-page scroll change, at least for the most important columns.