Repository navigation
Merged
Conversation
Gargron
approved these changes
Sep 11, 2019
Gargron
changed the title
Contributor
|
Why is opt-in the default? Shouldn't we opt out? |
Member
|
No, the default expectation for social media profiles is that they are findable. If I type in "eugen rochko linkedin" into Google I expect to see my profile rather than go and enable it separately in the innards of LinkedIn's settings area. If you think that that is not the expectation for your own community, that is why you now have this admin setting to control it. |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11750.
this is my first time working with both ruby and rails so i'm not quite sure where to put a test for this. i'd appreciate it if someone could point me in the right direction for that :)
testing the view for the
noindexmeta tag might be nice, but as far as i can tell things aren't really set up for that kind of integration testing?