Skip to content

Allow daysBeforeStale options to be float - #841

Merged
JoannaaKL merged 2 commits into
actions:mainfrom
irega:main
Oct 19, 2022
Merged

Allow daysBeforeStale options to be float#841
JoannaaKL merged 2 commits into
actions:mainfrom
irega:main

Conversation

@irega

@irega irega commented Oct 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Modifies the initialization of the input options daysBeforeStale, daysBeforeIssueStale and daysBeforePrStale to perform a parseFloat instead of parseInt.
  • Adds new test cases to cover the cases where those params are used with hours instead of full days.

Context

Resolves #833

@irega
irega marked this pull request as ready for review October 7, 2022 08:30
@irega
irega requested a review from a team as a code owner October 7, 2022 08:30
@irega

irega commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

@luketomlinson @rentziass @flaxel @JoannaaKL could you take a look at this PR? 🙏

@JoannaaKL
JoannaaKL merged commit 65b52af into actions:main Oct 19, 2022
@irega irega mentioned this pull request Dec 13, 2022
Closed
1 task done
@coderabbitai coderabbitai Bot mentioned this pull request Sep 15, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@JoannaaKL JoannaaKL JoannaaKL approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow daysBeforeStale options to be float

2 participants

@irega @JoannaaKL