Skip to content

client: minor improvements to log messages - #8564

Merged
easwars merged 1 commit into
grpc:masterfrom
easwars:minor_log_improvements
Sep 17, 2025
Merged

client: minor improvements to log messages#8564
easwars merged 1 commit into
grpc:masterfrom
easwars:minor_log_improvements

Conversation

@easwars

@easwars easwars commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Couple of minor improvements to log messages from the gRPC channel

The improvements are:

  • Log the target URI when we log a message for the creation of a gRPC channel
  • Separate the channelz identifier (which could be something like [Channel #X] or [Channel X][Subchannel Y] etc) from the actual message being logged with a space

RELEASE NOTES: none

@easwars
easwars requested a review from dfawley September 9, 2025 19:39
@easwars easwars added Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. Type: Internal Cleanup Refactors, etc labels Sep 9, 2025
@easwars easwars added this to the 1.76 Release milestone Sep 9, 2025
@easwars

easwars commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

I was debugging a scenario which had more than one gRPC channel to different target URIs. The lack of the target URI in the channel creation log was frustrating. We do log the different components of the parsed target URI later on, but this one is much easier when debugging.

@codecov

codecov Bot commented Sep 9, 2025

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 81.63%. Comparing base (e60a04b) to head (fc57dd7).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8564      +/-   ##
==========================================
- Coverage   81.64%   81.63%   -0.02%     
==========================================
  Files         413      413              
  Lines       40621    40621              
==========================================
- Hits        33167    33162       -5     
+ Misses       5991     5980      -11     
- Partials     1463     1479      +16     
Files with missing lines Coverage Ξ”
clientconn.go 90.07% <100.00%> (-0.28%) ⬇️
internal/channelz/trace.go 91.66% <100.00%> (ΓΈ)

... and 26 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfawley dfawley assigned easwars and unassigned dfawley Sep 16, 2025
@easwars
easwars merged commit 0513350 into grpc:master Sep 17, 2025
15 of 21 checks passed
@easwars
easwars deleted the minor_log_improvements branch November 25, 2025 07:08
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants