Skip to content

feat: allow esbuild 0.28 - #22743

Merged
sapphi-red merged 2 commits into
v7from
v7-extend-esbuild-range
Jun 25, 2026
Merged

sapphi-red merged 2 commits into
v7from
v7-extend-esbuild-range

Conversation

@bluwy

@bluwy bluwy commented Jun 23, 2026 •

Copy link
Copy Markdown
Member

for v7

close #22684

Usually we'd just bump the range, but given this is for v7, probably not worth changing too much? 0.28 also doesn't have any significant changes that could affect users.

@netlify

netlify Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

βœ… Deploy Preview for vite-docs-v7 ready!

Name Link
πŸ”¨ Latest commit 25479a3
πŸ” Latest deploy log https://app.netlify.com/projects/vite-docs-v7/deploys/6a3b41ae38efa1000857017a
😎 Deploy Preview https://deploy-preview-22743--vite-docs-v7.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
πŸ€– Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red

Copy link
Copy Markdown
Member

I think we can cut a patch for this esbuild upgrade.

The WebAssembly build now unconditionally makes use of the sign extension and non-trapping floating-point to integer conversion instructions.

I think this is the only breaking change. Both of these features are included in the supported dev browser range. So I think it's fine.

@sapphi-red

sapphi-red commented Jun 24, 2026 •

Copy link
Copy Markdown
Member

#22760 should fix the tests (pulled in here)

@sapphi-red sapphi-red added dependencies Pull requests that update a dependency file p2-nice-to-have Not breaking anything but nice to have (priority) labels Jun 24, 2026
@sapphi-red
sapphi-red merged commit a24931e into v7 Jun 25, 2026
19 checks passed
@sapphi-red
sapphi-red deleted the v7-extend-esbuild-range branch June 25, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants