Skip to content

build: JavaFX 19 -> 19.0.2.1 - #1223

Merged
AlmasB merged 2 commits into
AlmasB:devfrom
chengenzhao:dev
Jan 21, 2023
Merged

build: JavaFX 19 -> 19.0.2.1#1223
AlmasB merged 2 commits into
AlmasB:devfrom
chengenzhao:dev

Conversation

@chengenzhao

Copy link
Copy Markdown
Contributor

There is a bug which may cause JavaFX on Mac crash & JavaFX 19.0.2.1 fix this bug
see also:
openjdk/jfx#1003

There is a bug which may cause JavaFX on Mac crash & JavaFX 19.0.2.1 fix this bug, see also:
openjdk/jfx#1003
This is a missing version upgrade in previous pr
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1223 (d2e2596) into dev (b9d006b) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #1223      +/-   ##
============================================
- Coverage     58.67%   58.60%   -0.08%     
+ Complexity     2930     2927       -3     
============================================
  Files           303      303              
  Lines         15003    15003              
  Branches       1533     1533              
============================================
- Hits           8803     8792      -11     
- Misses         5696     5707      +11     
  Partials        504      504              
Impacted Files Coverage Δ
.../src/main/kotlin/com/almasb/fxgl/app/LoopRunner.kt 85.45% <0.00%> (-9.10%) ⬇️
fxgl/src/main/kotlin/com/almasb/fxgl/app/Engine.kt 73.23% <0.00%> (-8.46%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlmasB
AlmasB merged commit e28f3f0 into AlmasB:dev Jan 21, 2023
@AlmasB

AlmasB commented Jan 21, 2023

Copy link
Copy Markdown
Owner

Many thanks.

@asddcctrr143 asddcctrr143 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants