Repository navigation
Fix updateGroup --admin and --remove-member silent failures - #1970
Merged
AsamK merged 2 commits intoMar 13, 2026
Merged
Conversation
Fix type mismatch in retainAll() calls that cause updateGroup --admin and --remove-member to silently do nothing. retainAll() compared Set<RecipientId> against Collection<GroupMemberInfo>, which always evaluates to false (different types), emptying the set. Replace group.getMembers() with group.getMemberRecipientIds() in all three affected locations. Fixes: updateGroup --admin silently failing to promote members Fixes: updateGroup --remove-member silently failing to remove members
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type mismatch in retainAll() calls that cause updateGroup --admin and --remove-member to silently do nothing.
retainAll() compared Set against Collection, which always evaluates to false (different types), emptying the set.
Replace group.getMembers() with group.getMemberRecipientIds() in all three affected locations.
Fixes: updateGroup --admin silently failing to promote members
Fixes: updateGroup --remove-member silently failing to remove members
Raised in issue: #1969