Repository navigation
Add group story support via --group-id - #2083
Merged
Merged
Conversation
Owner
|
Needs a rebase, also I see some unrelated files that should be removed, |
Contributor
Author
Oops! Will do! |
Extend Manager.sendStory() with an optional GroupId parameter and add SendHelper.sendGroupStoryMessage() for endorsement-aware group story delivery, laying the groundwork for group story support (task 1 of 4). The existing My Story code path is unchanged.
Passes an optional GroupId through to Manager.sendStory so stories can be posted to a group instead of only My Story, and surfaces GroupNotFoundException / NotAGroupMemberException as user errors.
Updates DbusManagerImpl and StubManager (in SubscribeCallEventsTest) to match the new 3-parameter sendStory signature: (String attachment, boolean allowsReplies, Optional<GroupId> groupId). Also includes the empty-recipient guard added after Task 1 review to prevent stories from being sent to groups where the user is the only member. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MR2KF56Qcf9qNH1URj3XWs
- Add --group-id (-g) option to sendStory command in man page - Update CHANGELOG to mention group story support via --group-id - Maintain alphabetical order of options in sendStory section Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MR2KF56Qcf9qNH1URj3XWs
- Filter group story recipients by ACI type and endorsement availability to prevent ClassCastException and NPE on edge cases - Add empty-recipient guard after endorsement filtering - Skip known-unregistered recipients before address resolution, matching the pattern from sendGroupMessageInternal - Add debug logging when recipients are filtered out - Fix redundant error message prefixing in SendStoryCommand - Add .superpowers/ to .gitignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MR2KF56Qcf9qNH1URj3XWs
Contributor
Author
|
Done. |
AsamK
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendStorywith optional--group-id/-gparameter for posting stories to Signal groupsgetGroupSendEndorsements()Changes
Optional<GroupId>third parameter-g/--group-idargument with error handlingTest plan
./gradlew compileJava compileTestJava test)🤖 Generated with Claude Code
https://claude.ai/code/session_01MR2KF56Qcf9qNH1URj3XWs