Repository navigation
Added base64 encoded attachment support - #966
Merged
Merged
Conversation
Owner
|
Thanks, i like the approach with using a data url. |
Contributor
Author
|
Where can I find the comments? |
AsamK
reviewed
Jun 3, 2022
Owner
|
You should see them now, i forgot to submit them... |
Contributor
Author
AsamK
reviewed
Jun 3, 2022
Contributor
Author
|
@AsamK Added feedback. Your data URI should work now. |
Owner
|
Thanks! |
Contributor
|
Which filename is used if none is provided? |
Owner
|
none ;) |
Contributor
|
Can the Signal app deal with received attachments with no name? |
Contributor
Author
|
Yes. It can |
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for base64 encoded attachments (see also #679 (comment)).
Tested via: