Skip to content

chore: update known_skus - #1734

Merged
Matthew Christopher (matthchr) merged 4 commits into
mainfrom
matthchr/update-known-skus
Jul 16, 2026
Merged

Matthew Christopher (matthchr) merged 4 commits into
mainfrom
matthchr/update-known-skus

Conversation

@matthchr

@matthchr Matthew Christopher (matthchr) commented Jun 18, 2026 •

Copy link
Copy Markdown
Member

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@GuetaHen

Copy link
Copy Markdown
Contributor

Thanks for consolidating the known-SKU additions here! It looks like the 8 Dals_v5 (AMD-based) sizes from my closed PR #1724 didn't get carried over into this update. Could we include the standardDALSv5Family entries as well?

Standard_D2als_v5
Standard_D4als_v5
Standard_D8als_v5
Standard_D16als_v5
Standard_D32als_v5
Standard_D48als_v5
Standard_D64als_v5
Standard_D96als_v5

@matthchr

Matthew Christopher (matthchr) commented Jun 18, 2026 •

Copy link
Copy Markdown
Member Author

Thanks for consolidating the known-SKU additions here! It looks like the 8 Dals_v5 (AMD-based) sizes from my closed PR #1724 didn't get carried over into this update. Could we include the standardDALSv5Family entries as well?

Standard_D2als_v5 Standard_D4als_v5 Standard_D8als_v5 Standard_D16als_v5 Standard_D32als_v5 Standard_D48als_v5 Standard_D64als_v5 Standard_D96als_v5

Hmm you're right -- I can't seem to find public docs for those sizes either though, nor can I see them in the Azure VM List SKUs.

There's a v6 and v7:
https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/general-purpose/dalsv7-series?tabs=sizebasic
https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/general-purpose/dalsv6-series?tabs=sizebasic

We build this list via Azure VM List SKUs so if they're not showing up in that API they won't be in the updated file. (We also rely on List SKUs for other things so even if I manually put them in this file they won't work if they're not there).

edit: I also do not see those sizes in the pricing API either

Do these sizes actually exist?

@matthchr

Matthew Christopher (matthchr) commented Jun 18, 2026 •

Copy link
Copy Markdown
Member Author

The new sizes seem to be, due to capacity/allocation issues?

  [FAIL] NewSKUs [It] should provision a node for family D_v7 (Standard_D4s_v7)
  /usr/local/vss-agent/2.335.1/_work/karpenter-provider-azure/karpenter-provider-azure/test/suites/newskus/newskus_test.go:71
  [FAIL] NewSKUs [It] should provision a node for family Dam (Standard_D4darm_V3)
  /usr/local/vss-agent/2.335.1/_work/karpenter-provider-azure/karpenter-provider-azure/test/suites/newskus/newskus_test.go:71
  [FAIL] NewSKUs [It] should provision a node for family E_v7 (Standard_E4s_v7)
  /usr/local/vss-agent/2.335.1/_work/karpenter-provider-azure/karpenter-provider-azure/test/suites/newskus/newskus_test.go:71
  [FAIL] NewSKUs [It] should provision a node for family Eam (Standard_E4darm_V3)
  /usr/local/vss-agent/2.335.1/_work/karpenter-provider-azure/karpenter-provider-azure/test/suites/newskus/newskus_test.go:71
  [FAIL] NewSKUs [It] should provision a node for family standardNDISRGB200V6NDRFamily (Standard_ND128isr_NDR_GB200_v6)

Though none of them seem to actually function right now

@GuetaHen

Copy link
Copy Markdown
Contributor

Strange, I am able to create classic CAS nodepool using those V5 low memory amd skus

@matthchr

Copy link
Copy Markdown
Member Author

Strange, I am able to create classic CAS nodepool using those V5 low memory amd skus

Just an update that I followed up offline and we determined that there seems to be some mention/quota for DALSv5 but no actual VM size of that kind. This PR is still worth doing for the other sizes it adds but we are not expecting it to add support for DALSv5 at the moment

Maximiliano Uribe Falcon (MaximilianoUribe) added a commit that referenced this pull request Jul 10, 2026
known_skus.yaml inventory update for the RTX PRO 6000 GA sizes is being
made in #1734 (full regen). Keep this PR scoped to the GPU registry and
driver routing to avoid conflicting edits to the generated file.
@matthchr

Matthew Christopher (matthchr) commented Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

Ok now I've gotten things somewhat working:

From a manual testpass, since not all sizes are available in all regions yet:

AZURE_LOCATION=eastus2 FOCUS="Standard_D4s_v7|Standard_E4s_v7" TEST_SUITE=newskus make az-e2etests

  === NewSKUs Test Summary ===
       Canonical Family               Variant Family                      VM Size                        Result     Reason
  -------------------------------------------------------------------------------------------------------------------------------------------------
  βœ…    D_v7                           StandardDsv7Family                  Standard_D4s_v7                PASS       
  πŸ”—    D_v7                           StandardDdsv7Family                 Standard_D128ds_v7             INFERRED PASS 
  πŸ”—    D_v7                           StandardDldsv7Family                Standard_D128lds_v7            INFERRED PASS 
  πŸ”—    D_v7                           StandardDlsv7Family                 Standard_D128ls_v7             INFERRED PASS 
  ❓    Dam                            standardARMv3Family                 Standard_D4darm_V3             NOT RUN    
  βœ…    E_v7                           StandardEsv7Family                  Standard_E4s_v7                PASS       
  πŸ”—    E_v7                           StandardEdsv7Family                 Standard_E128ds_v7             INFERRED PASS 
  ❓    Eam                            standardARMv3Family                 Standard_E4darm_V3             NOT RUN    
  ⏭️   NC_v6                          StandardNCdsRTXPRO6000BSEv6XLFamily Standard_NC36ds_xl_RTXPRO6000BSE_v6 SKIPPED    insufficient quota: 0 available, 36 needed for StandardNCdsRTXPRO6000BSEv6XLFamily
  ⏭️   standardNDISRGB200V6NDRFamily  standardNDISRGB200V6NDRFamily       Standard_ND128isr_NDR_GB200_v6 SKIPPED    insufficient quota: 0 available, 4 needed for standardNDISRGB200V6NDRFamily

AZURE_LOCATION=eastus2euap FOCUS="Standard_D4darm_V3" TEST_SUITE=newskus make az-e2etests

  > Enter [AfterSuite] TOP-LEVEL - /workspaces/karpenter-provider-azure/test/suites/newskus/suite_test.go:95 @ 07/16/26 04:54:18.255

  === NewSKUs Test Summary ===
       Canonical Family               Variant Family                      VM Size                        Result     Reason
  -------------------------------------------------------------------------------------------------------------------------------------------------
  ❓    D_v7                           StandardDsv7Family                  Standard_D4s_v7                NOT RUN    
  βœ…    Dam                            standardARMv3Family                 Standard_D4darm_V3             PASS       
  ❓    E_v7                           StandardEsv7Family                  Standard_E4s_v7                NOT RUN    
  ❓    Eam                            standardARMv3Family                 Standard_E4darm_V3             NOT RUN    
  ⏭️   NC_v6                          StandardNCdsRTXPRO6000BSEv6XLFamily Standard_NC36ds_xl_RTXPRO6000BSE_v6 SKIPPED    insufficient quota: 0 available, 36 needed for StandardNCdsRTXPRO6000BSEv6XLFamily
  ⏭️   standardNDISRGB200V6NDRFamily  standardNDISRGB200V6NDRFamily       Standard_ND128isr_NDR_GB200_v6 SKIPPED    insufficient quota: 0 available, 4 needed for standardNDISRGB200V6NDRFamily

  Direct: 6 tested | 1 passed | 0 failed | 2 skipped

@matthchr

Matthew Christopher (matthchr) commented Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

I removed both Dam/Eam families because they don't seem to be fully public yet. I was able to get Dam to work but the family name standardARMv3Family seems wrong to me (it doesn't say D or E?).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some uts failing, can reapprove when fixed

@matthchr
Matthew Christopher (matthchr) merged commit 2b431da into main Jul 16, 2026
13 of 14 checks passed
@matthchr
Matthew Christopher (matthchr) deleted the matthchr/update-known-skus branch July 16, 2026 22:49
lnguyen924 pushed a commit that referenced this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants