Repository navigation
fix: use Microsoft Go for FIPS-compliant release builds - #1887
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
π‘ Changes recommended
The workflow change can fail when go.mod pins a Go version that no longer matches the Microsoft βlatestβ endpoint due to removing check-latest: true.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the shared GitHub composite action used for dependency/toolchain setup so that release builds install Go from Microsoftβs official distribution endpoint (to support FIPS-compliant builds using systemcrypto/OpenSSL on Linux).
Changes:
- Configures
actions/setup-goto download Go fromhttps://aka.ms/golang/release/latest. - Updates the toolchain cache key to avoid collisions with caches produced by the non-Microsoft Go distribution.
File summaries
| File | Description |
|---|---|
| .github/actions/install-deps/action.yaml | Switches setup-go download source to Microsoft Go and updates the toolchain cache key accordingly. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
π’ Approval recommended
The changes are narrowly scoped to CI/toolchain configuration and an image digest update, and the repoβs workflows consistently use the shared install-deps action.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
π‘ Changes recommended
Harden-runner allowlists add aka.ms but omit the typical redirect target (download.microsoft.com), which can break Go toolchain downloads under egress-policy: block.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Previously missed (1) β in code that hasn't changed since the last review.
.github/actions/install-deps/action.yaml:15
- Severity: High | Category: Security β
go-download-base-url: https://aka.ms/golang/release/latestuses a redirecting shortlink; the actual Microsoft Go binaries are commonly served fromdownload.microsoft.com. Any workflow using harden-runner withegress-policy: blockwill need to allowlist the redirect target (and any other redirect host) oractions/setup-gocan fail when it tries to fetch the toolchain.
Update the harden-runner allowed-endpoints lists accordingly (notably .github/workflows/e2e.yaml currently has aka.ms:443 but not download.microsoft.com:443).
- Files reviewed: 7/7 changed files
- Comments generated: 5
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
π‘ Changes recommended
The install-deps action now follows aka.ms redirects for Go downloads, but the egress-blocked E2E workflow allowlist is not updated to permit the redirect target hosts, which will break E2E runs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Previously missed (1) β in code that hasn't changed since the last review.
.github/workflows/label-sync.yaml:26
- Severity: Low | Category: Correctness β The
allowed-endpointslist contains duplicated entries (azure.archive.ubuntu.com,packages.microsoft.com,esm.ubuntu.com). This makes the allowlist harder to audit and maintain, especially now that more endpoints are being added for Microsoft Go downloads.
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
Description
Configure the shared dependency setup action to download the Go toolchain from the Microsoft Go distribution while continuing to resolve the version from go.mod. This ensures release builds use Microsoft Go systemcrypto/OpenSSL on Linux. Also update the toolchain cache namespace to avoid collisions with caches produced by the standard Go distribution.
The Microsoft shortlink redirects to download.visualstudio.microsoft.com (with download.microsoft.com also allowed), so all blocked HardenRunner workflows using the shared installer permit the redirect targets.
Update the pinned Azure Linux 3 distroless base image digest to the newer 3.0.20260809 release.
How was this change tested?
Does this change impact docs?
Release Note