Repository navigation
chore: node image pinning follow up - #1960
Merged
Pablo Trivino (PabloTriv) merged 14 commits intoOct 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Follow-up changes to improve observability of discovered supported Kubernetes versions and to extend NodeImage status controller coverage for Shared Image Gallery (SIG) scenarios.
Changes:
- Add conditional logging when supported Kubernetes versions change.
- Add SIG-specific NodeImage reconciler tests, mirroring existing Community Image Gallery behaviors.
| File | Description |
|---|---|
| pkg/βproviders/βkubernetesversion/βkubernetesversion.go | Adds change-detected logging for supported Kubernetes versions. |
| pkg/βcontrollers/βnodeclass/βstatus/βimages_test.go | Adds direct SIG-focused test coverage for NodeImage reconciliation and maintenance-window behavior. |
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pablo Trivino (PabloTriv)
force-pushed
the
pablotrivino/nodeImagePinningFollowUp
branch
from
October 6, 2026 17:44
1464c0b to
4d94347
Compare
Matthew Christopher (matthchr)
approved these changes
Oct 9, 2026
Pablo Trivino (PabloTriv)
force-pushed
the
pablotrivino/nodeImagePinningFollowUp
branch
from
October 9, 2026 16:27
5183fc0 to
dc621d1
Compare
Pablo Trivino (PabloTriv)
force-pushed
the
pablotrivino/nodeImagePinningFollowUp
branch
from
October 12, 2026 14:41
dc621d1 to
763cd90
Compare
Pablo Trivino (PabloTriv)
deleted the
pablotrivino/nodeImagePinningFollowUp
branch
October 12, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #
Description
Follows up on adding cm integration and SIG testing
How was this change tested?
Does this change impact docs?
Release Note