Skip to content

chore: node image pinning follow up - #1960

Merged
Pablo Trivino (PabloTriv) merged 14 commits into
mainfrom
pablotrivino/nodeImagePinningFollowUp
Oct 12, 2026
Merged

Pablo Trivino (PabloTriv) merged 14 commits into
mainfrom
pablotrivino/nodeImagePinningFollowUp

Conversation

@PabloTriv

@PabloTriv Pablo Trivino (PabloTriv) commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #

Description
Follows up on adding cm integration and SIG testing
How was this change tested?

  • Unit tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copilot AI balanced review requested due to automatic review settings October 2, 2026 20:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 Medium severity Β· 1 Low severity

Open (2)
What changed in this PR

Follow-up changes to improve observability of discovered supported Kubernetes versions and to extend NodeImage status controller coverage for Shared Image Gallery (SIG) scenarios.

Changes:

  • Add conditional logging when supported Kubernetes versions change.
  • Add SIG-specific NodeImage reconciler tests, mirroring existing Community Image Gallery behaviors.
File Description
pkg/​providers/​kubernetesversion/​kubernetesversion.go Adds change-detected logging for supported Kubernetes versions.
pkg/​controllers/​nodeclass/​status/​images_test.go Adds direct SIG-focused test coverage for NodeImage reconciliation and maintenance-window behavior.

πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟒 Approval recommended

The changes are focused, consistent with existing behavior, and introduce no unresolved correctness issues.

Review effort: Balanced
Findings: 1 Medium severity Β· 1 Low severity

Open (2)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟒 Approval recommended

The changes are focused, consistent with existing patterns, and adequately covered by tests.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

@PabloTriv
Pablo Trivino (PabloTriv) force-pushed the pablotrivino/nodeImagePinningFollowUp branch from 1464c0b to 4d94347 Compare October 6, 2026 17:44
Copilot AI balanced review requested due to automatic review settings October 6, 2026 17:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟒 Approval recommended

The changes are scoped, consistent with existing CIG behavior, and adequately tested.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI balanced review requested due to automatic review settings October 6, 2026 19:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟑 Changes recommended

The SIG direct-test suite is duplicated, unnecessarily increasing test runtime and maintenance burden.

Review effort: Balanced
Findings: 1 Low severity

Open (1)

Copilot AI balanced review requested due to automatic review settings October 6, 2026 23:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟒 Approval recommended

The changes are focused, consistent with existing behavior, and introduce no unresolved correctness issues.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@PabloTriv Pablo Trivino (PabloTriv) changed the title Pablotrivino/node image pinning follow up chore: node image pinning follow up Oct 7, 2026
@PabloTriv
Pablo Trivino (PabloTriv) force-pushed the pablotrivino/nodeImagePinningFollowUp branch from 5183fc0 to dc621d1 Compare October 9, 2026 16:27
@PabloTriv
Pablo Trivino (PabloTriv) force-pushed the pablotrivino/nodeImagePinningFollowUp branch from dc621d1 to 763cd90 Compare October 12, 2026 14:41
@PabloTriv
Pablo Trivino (PabloTriv) merged commit f9fb021 into main Oct 12, 2026
13 checks passed
@PabloTriv
Pablo Trivino (PabloTriv) deleted the pablotrivino/nodeImagePinningFollowUp branch October 12, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants