Repository navigation
chore: windows CRD updates to v1alpha2 - #1966
Merged
Robin D. (comtalyst) merged 2 commits intoOct 7, 2026
Merged
Robin D. (comtalyst) merged 2 commits into
Robin D. (comtalyst) merged 2 commits into
Conversation
Mirror the Windows image family enum and validation rules into the retained v1alpha2 schema so server-side apply can process objects with historical v1alpha2 managed fields. Co-Authored-By: Claude <noreply@anthropic.com>
1 of 3 tasks
Robin D. (comtalyst)
marked this pull request as ready for review
October 6, 2026 08:20
Contributor
There was a problem hiding this comment.
Copilot review overview
π’ Approval recommended
The retained schema now consistently mirrors v1beta1 while remaining deprecated and unserved.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the retained, unserved v1alpha2 schema for server-side apply compatibility with Windows AKSNodeClasses.
Changes:
- Adds Windows2022 and Windows2025 image families and matching v1beta1 validation rules.
- Adds legacy-schema validation coverage.
- Regenerates both CRD copies.
| File | Description |
|---|---|
pkg/βapis/βv1alpha2/βlabels.go |
Defines Windows image-family constants. |
pkg/βapis/βv1alpha2/βcrd_validation_cel_test.go |
Tests Windows validation behavior. |
pkg/βapis/βv1alpha2/βaksnodeclass.go |
Mirrors v1beta1 Windows schema validation. |
pkg/βapis/βcrds/βkarpenter.azure.com_aksnodeclasses.yaml |
Updates the generated CRD. |
charts/βkarpenter-crd/βtemplates/βkarpenter.azure.com_aksnodeclasses.yaml |
Updates the generated chart CRD. |
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Matthew Christopher (matthchr)
approved these changes
Oct 6, 2026
Robin D. (comtalyst)
deleted the
robin/task10219-windows-v1alpha2-ssa-compat-20261002
branch
October 7, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Server-side apply can consult the retained v1alpha2 schema when an existing AKSNodeClass has managed fields recorded in that version. That schema does not recognize Windows2022 or Windows2025.
Mirror the Windows image-family values and validation rules from v1beta1 into the retained schema for managed-fields compatibility. v1alpha2 remains deprecated and unserved.
#1925 is stacked on this PR because both update the generated AKSNodeClass CRDs.
How was this change tested?
Does this change impact docs?
Release Note