Skip to content

chore: windows CRD updates to v1alpha2 - #1966

Merged
Robin D. (comtalyst) merged 2 commits into
mainfrom
robin/task10219-windows-v1alpha2-ssa-compat-20261002
Oct 7, 2026
Merged

Robin D. (comtalyst) merged 2 commits into
mainfrom
robin/task10219-windows-v1alpha2-ssa-compat-20261002

Conversation

@comtalyst

@comtalyst Robin D. (comtalyst) commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Server-side apply can consult the retained v1alpha2 schema when an existing AKSNodeClass has managed fields recorded in that version. That schema does not recognize Windows2022 or Windows2025.

Mirror the Windows image-family values and validation rules from v1beta1 into the retained schema for managed-fields compatibility. v1alpha2 remains deprecated and unserved.

#1925 is stacked on this PR because both update the generated AKSNodeClass CRDs.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened
  • No

Release Note

NONE

Mirror the Windows image family enum and validation rules into the retained v1alpha2 schema so server-side apply can process objects with historical v1alpha2 managed fields.

Co-Authored-By: Claude <noreply@anthropic.com>
@comtalyst Robin D. (comtalyst) changed the title fix: preserve Windows image family apply compatibility chore: windows CRD updates to v1alpha2 Oct 6, 2026
@comtalyst
Robin D. (comtalyst) marked this pull request as ready for review October 6, 2026 08:20
Copilot AI balanced review requested due to automatic review settings October 6, 2026 08:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟒 Approval recommended

The retained schema now consistently mirrors v1beta1 while remaining deprecated and unserved.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the retained, unserved v1alpha2 schema for server-side apply compatibility with Windows AKSNodeClasses.

Changes:

  • Adds Windows2022 and Windows2025 image families and matching v1beta1 validation rules.
  • Adds legacy-schema validation coverage.
  • Regenerates both CRD copies.
File Description
pkg/​apis/​v1alpha2/​labels.go Defines Windows image-family constants.
pkg/​apis/​v1alpha2/​crd_validation_cel_test.go Tests Windows validation behavior.
pkg/​apis/​v1alpha2/​aksnodeclass.go Mirrors v1beta1 Windows schema validation.
pkg/​apis/​crds/​karpenter.azure.com_aksnodeclasses.yaml Updates the generated CRD.
charts/​karpenter-crd/​templates/​karpenter.azure.com_aksnodeclasses.yaml Updates the generated chart CRD.

πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 23:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟒 Approval recommended

The retained schema now consistently mirrors v1beta1 Windows values and validations with matching tests and generated artifacts.

Review effort: Balanced
Findings: None

@comtalyst
Robin D. (comtalyst) merged commit 41357fa into main Oct 7, 2026
14 checks passed
@comtalyst
Robin D. (comtalyst) deleted the robin/task10219-windows-v1alpha2-ssa-compat-20261002 branch October 7, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants