Skip to content

fix: pricing collisions due to multiple entries with same VM size - #2002

Merged
Matthew Christopher (matthchr) merged 3 commits into
Azure:mainfrom
matthchr:matthchr/fix-pricing-collisions
Oct 16, 2026
Merged

Matthew Christopher (matthchr) merged 3 commits into
Azure:mainfrom
matthchr:matthchr/fix-pricing-collisions

Conversation

@matthchr

Copy link
Copy Markdown
Member

Fixes #1997.

How was this change tested?

  • Unit tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copilot AI balanced review requested due to automatic review settings October 13, 2026 19:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟑 Changes recommended

Duplicate fallback remains nondeterministic and can still cause prices to fluctuate.

1 open finding
What changed in this PR

Filters Cloud Services pricing rows to prevent unstable VM pricing and consolidation churn.

Changes:

  • Excludes Cloud Services products from pricing.
  • Logs duplicate SKU price conflicts.
  • Adds filtering tests and codegen guidance.
File Description
pkg/​providers/​pricing/​pricing.go Filters Cloud Services rows and detects collisions.
pkg/​providers/​pricing/​suite_test.go Tests Cloud Services filtering.
Makefile Clarifies pricing generation behavior.

🧠 Review effort: Balanced


πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/providers/pricing/pricing.go Resolved
@matthchr
Matthew Christopher (matthchr) merged commit 2400729 into Azure:main Oct 16, 2026
14 checks passed
@matthchr
Matthew Christopher (matthchr) deleted the matthchr/fix-pricing-collisions branch October 16, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On-demand price for Dasv5/Dadsv5 randomly switches between the Linux and Cloud Services retail rows, causing replace-consolidation churn

3 participants