Repository navigation
fix: pricing collisions due to multiple entries with same VM size - #2002
Merged
Matthew Christopher (matthchr) merged 3 commits intoOct 16, 2026
Merged
Matthew Christopher (matthchr) merged 3 commits into
Matthew Christopher (matthchr) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
π‘ Changes recommended
Duplicate fallback remains nondeterministic and can still cause prices to fluctuate.
1 open finding
What changed in this PR
Filters Cloud Services pricing rows to prevent unstable VM pricing and consolidation churn.
Changes:
- Excludes Cloud Services products from pricing.
- Logs duplicate SKU price conflicts.
- Adds filtering tests and codegen guidance.
| File | Description |
|---|---|
pkg/βproviders/βpricing/βpricing.go |
Filters Cloud Services rows and detects collisions. |
pkg/βproviders/βpricing/βsuite_test.go |
Tests Cloud Services filtering. |
Makefile |
Clarifies pricing generation behavior. |
π§ Review effort: Balanced
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Matthew Christopher (matthchr)
force-pushed
the
matthchr/fix-pricing-collisions
branch
from
October 15, 2026 22:55
9e44f91 to
16a2774
Compare
Matthew Christopher (matthchr)
force-pushed
the
matthchr/fix-pricing-collisions
branch
from
October 16, 2026 18:41
e31c33f to
a4a035d
Compare
Alex Leites (tallaxes)
approved these changes
Oct 16, 2026
Matthew Christopher (matthchr)
deleted the
matthchr/fix-pricing-collisions
branch
October 16, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1997.
How was this change tested?
Does this change impact docs?
Release Note