Repository navigation
chore: use enum-scoped validation consistently when enum types defined - #2007
Merged
Matthew Christopher (matthchr) merged 1 commit intoOct 16, 2026
Conversation
Contributor
There was a problem hiding this comment.
π’ Approval recommended
The annotation-only changes preserve existing validation constraints, with no unresolved findings.
0 open findings
What changed in this PR
Centralizes existing enum validation on API types rather than individual fields, without changing allowed values or optionality.
Changes:
- Moves FIPS mode and OS disk type validation onto their enum types.
- Moves LocalDNS state validation onto its enum type in both API versions.
| File | Description |
|---|---|
pkg/βapis/βv1beta1/βaksnodeclass.go |
Relocates FIPS and OS disk enum markers. |
pkg/βapis/βv1beta1/βaksnodeclass_status.go |
Relocates LocalDNS state enum marker. |
pkg/βapis/βv1alpha2/βaksnodeclass.go |
Applies equivalent spec marker relocations. |
pkg/βapis/βv1alpha2/βaksnodeclass_status.go |
Applies equivalent status marker relocation. |
π§ Review effort: Balanced
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bevan Arps (theunrepentantgeek)
approved these changes
Oct 16, 2026
Matthew Christopher (matthchr)
deleted the
matthchr/normalize-enum-validation
branch
October 16, 2026 00:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How was this change tested?
Does this change impact docs?
Release Note