Skip to content

chore: use enum-scoped validation consistently when enum types defined - #2007

Merged
Matthew Christopher (matthchr) merged 1 commit into
Azure:mainfrom
matthchr:matthchr/normalize-enum-validation
Oct 16, 2026
Merged

Matthew Christopher (matthchr) merged 1 commit into
Azure:mainfrom
matthchr:matthchr/normalize-enum-validation

Conversation

@matthchr

Copy link
Copy Markdown
Member

How was this change tested?

  • Unit tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copilot AI balanced review requested due to automatic review settings October 15, 2026 23:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Approval recommended

The annotation-only changes preserve existing validation constraints, with no unresolved findings.

0 open findings

What changed in this PR

Centralizes existing enum validation on API types rather than individual fields, without changing allowed values or optionality.

Changes:

  • Moves FIPS mode and OS disk type validation onto their enum types.
  • Moves LocalDNS state validation onto its enum type in both API versions.
File Description
pkg/​apis/​v1beta1/​aksnodeclass.go Relocates FIPS and OS disk enum markers.
pkg/​apis/​v1beta1/​aksnodeclass_status.go Relocates LocalDNS state enum marker.
pkg/​apis/​v1alpha2/​aksnodeclass.go Applies equivalent spec marker relocations.
pkg/​apis/​v1alpha2/​aksnodeclass_status.go Applies equivalent status marker relocation.

🧠 Review effort: Balanced


πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@matthchr
Matthew Christopher (matthchr) merged commit 2bfcc1a into Azure:main Oct 16, 2026
14 checks passed
@matthchr
Matthew Christopher (matthchr) deleted the matthchr/normalize-enum-validation branch October 16, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants