Repository navigation
chore: remove testify, use gomega - #2019
Merged
Matthew Christopher (matthchr) merged 1 commit intoOct 22, 2026
Merged
Matthew Christopher (matthchr) merged 1 commit into
Matthew Christopher (matthchr) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
π’ Approval recommended
The mechanical test migration preserves the existing checks and introduces no identified correctness regressions.
No open issues π
What changed in this PR
Standardizes the Azure providerβs remaining Testify-based tests on Gomega without changing production behavior.
Changes:
- Replaces Testify assertions with Gomega matchers in four test files.
- Uses test-local Gomega instances, including in parallel subtests.
- Removes Testify from the direct dependencies in
go.mod.
| File | Description |
|---|---|
pkg/βproviders/βinstance/βaksmachinepoller/βpoller_test.go |
Migrates polling state, retry, and error assertions to Gomega. |
pkg/βproviders/βazclient/βno_client_test.go |
Migrates fallback-client error assertions to Gomega. |
pkg/βproviders/βazclient/βmachineslistexpand_test.go |
Migrates list-expansion request assertions to Gomega. |
pkg/βfake/βsync/βmap_test.go |
Migrates synchronized map assertions to Gomega. |
go.mod |
Removes the direct Testify dependency. |
Review effort: Balanced
Matthew Christopher (matthchr)
force-pushed
the
matthchr/remove-testify-2
branch
from
October 22, 2026 18:10
6a532b4 to
2a3d770
Compare
Maximiliano Uribe Falcon (MaximilianoUribe)
approved these changes
Oct 22, 2026
Maximiliano Uribe Falcon (MaximilianoUribe)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
Matthew Christopher (matthchr)
merged commit Oct 22, 2026
4a10721
into
Azure:main
16 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this change impact docs?
Release Note