Skip to content

chore: remove testify, use gomega - #2019

Merged
Matthew Christopher (matthchr) merged 1 commit into
Azure:mainfrom
matthchr:matthchr/remove-testify-2
Oct 22, 2026
Merged

Matthew Christopher (matthchr) merged 1 commit into
Azure:mainfrom
matthchr:matthchr/remove-testify-2

Conversation

@matthchr

Copy link
Copy Markdown
Member

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copilot AI balanced review requested due to automatic review settings October 22, 2026 18:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Approval recommended

The mechanical test migration preserves the existing checks and introduces no identified correctness regressions.

No open issues πŸŽ‰

What changed in this PR

Standardizes the Azure provider’s remaining Testify-based tests on Gomega without changing production behavior.

Changes:

  • Replaces Testify assertions with Gomega matchers in four test files.
  • Uses test-local Gomega instances, including in parallel subtests.
  • Removes Testify from the direct dependencies in go.mod.
File Description
pkg/​providers/​instance/​aksmachinepoller/​poller_test.go Migrates polling state, retry, and error assertions to Gomega.
pkg/​providers/​azclient/​no_client_test.go Migrates fallback-client error assertions to Gomega.
pkg/​providers/​azclient/​machineslistexpand_test.go Migrates list-expansion request assertions to Gomega.
pkg/​fake/​sync/​map_test.go Migrates synchronized map assertions to Gomega.
go.mod Removes the direct Testify dependency.

Review effort: Balanced

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthchr
Matthew Christopher (matthchr) merged commit 4a10721 into Azure:main Oct 22, 2026
16 of 18 checks passed
@matthchr
Matthew Christopher (matthchr) deleted the matthchr/remove-testify-2 branch October 22, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants