Skip to content

docs(PR template): remove unused release note section - #2046

Merged
Robin D. (comtalyst) merged 1 commit into
mainfrom
comtalyst/pr-template-remove-misleading-release-note-section
Nov 5, 2026
Merged

Robin D. (comtalyst) merged 1 commit into
mainfrom
comtalyst/pr-template-remove-misleading-release-note-section

Conversation

@comtalyst

@comtalyst Robin D. (comtalyst) commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #

Description

That section is only consumed by prow in which we don't yet have. Leaving it here is misleading. Karpenter core and AWS provider also don't have it anymore.
Adding that functionality is a different consideration.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Copilot AI balanced review requested due to automatic review settings November 3, 2026 01:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Approval recommended

No active review issues are recorded for the removal of the unused release-note section from the contributor PR template.

No open issues πŸŽ‰

What changed in this PR

Simplifies the contributor PR template by removing the unused release-note section, which the repository does not currently consume.

Changes:

  • Removes the release-note heading, instructions, and fenced block.
  • Keeps the description, testing, and documentation-impact prompts unchanged.
File Description
.github/​pull-request-template.md Removes the unused release-note section.

Review effort: Balanced

@tallaxes Alex Leites (tallaxes) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with removing this, if we are not using / planning to use it consistently. At the same time, even though the formatting is Prow-shaped, just having an explicit release note seems useful. Wilson (@wdarko1) for an opinion.

@comtalyst

Copy link
Copy Markdown
Collaborator Author

Yes, and let's add it back once we consistently use it. Otherwise it will be a trap to lower our guard.

@comtalyst
Robin D. (comtalyst) merged commit a78c0c8 into main Nov 5, 2026
15 checks passed
@comtalyst
Robin D. (comtalyst) deleted the comtalyst/pr-template-remove-misleading-release-note-section branch November 5, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants