Repository navigation
docs(PR template): remove unused release note section - #2046
Merged
Robin D. (comtalyst) merged 1 commit intoNov 5, 2026
Merged
Robin D. (comtalyst) merged 1 commit into
Robin D. (comtalyst) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
π’ Approval recommended
No active review issues are recorded for the removal of the unused release-note section from the contributor PR template.
No open issues π
What changed in this PR
Simplifies the contributor PR template by removing the unused release-note section, which the repository does not currently consume.
Changes:
- Removes the release-note heading, instructions, and fenced block.
- Keeps the description, testing, and documentation-impact prompts unchanged.
| File | Description |
|---|---|
.github/βpull-request-template.md |
Removes the unused release-note section. |
Review effort: Balanced
Alex Leites (tallaxes)
approved these changes
Nov 5, 2026
Alex Leites (tallaxes)
left a comment
Collaborator
There was a problem hiding this comment.
I am ok with removing this, if we are not using / planning to use it consistently. At the same time, even though the formatting is Prow-shaped, just having an explicit release note seems useful. Wilson (@wdarko1) for an opinion.
Collaborator
Author
|
Yes, and let's add it back once we consistently use it. Otherwise it will be a trap to lower our guard. |
Robin D. (comtalyst)
deleted the
comtalyst/pr-template-remove-misleading-release-note-section
branch
November 5, 2026 01:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
That section is only consumed by prow in which we don't yet have. Leaving it here is misleading. Karpenter core and AWS provider also don't have it anymore.
Adding that functionality is a different consideration.
How was this change tested?
Does this change impact docs?