This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Properly guard read_write chain APIs during read-only and irreversible read modes #7671
Description
Both chain_apis::read_write::validate() and controller::push_transaction currently only validate that the controller read-mode is not chain::db_read_mode::READ_ONLY when it should also ensure it is not chain::db_read_mode::IRREVERSIBLE either. Furthermore, controller::push_scheduled_transaction does do any validation on the read-mode even though calls to it shouldn't be allowed during irreversible or read-only modes similar to controller::push_transaction.
Activity
arhag commentedon Jul 25, 2019
Also ensure producer plugin is in
start_block_result::waitingmode when the controller read-mode ischain::db_read_mode::IRREVERSIBLE.Relevant code:
eos/plugins/producer_plugin/producer_plugin.cpp
Lines 1311 to 1312 in 9562185
Merge pull request #8056 from EOSIO/issue_7671
arhag commentedon Oct 16, 2019
Resolved by #8056.