Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

[release 2.0.x] Fix docker steps on tagged builds. - #10063

Merged
scottarnette merged 2 commits into
release/2.0.xfrom
sa/fix-docker-publish-tags-r2.0
Feb 26, 2021
Merged

scottarnette merged 2 commits into
release/2.0.xfrom
sa/fix-docker-publish-tags-r2.0

Conversation

@scottarnette

Copy link
Copy Markdown
Contributor

Change Description

Logic that required a tagged build to function was finally exercised and exposed some errors when building eosio containers.

  • Fixed incorrect tagging step to use BUILD_TAG instead of defaulting to latest.
  • Add missing push step before removing the tag.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@kj4ezj kj4ezj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿณ

@scottarnette
scottarnette force-pushed the sa/fix-docker-publish-tags-r2.0 branch from 2f1b21c to 5844b8b Compare February 26, 2021 03:00
@scottarnette
scottarnette merged commit e929ab5 into release/2.0.x Feb 26, 2021
@scottarnette
scottarnette deleted the sa/fix-docker-publish-tags-r2.0 branch February 26, 2021 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants