[spoonincode]

Change Description

This removed copy needs to do nothing, otherwise the test cannot pass because an opened (and thus dirty) reversible block database gets copied to the new chain data directory and cannot be used because it is dirty. Indeed, this copy did nothing until boost 1.74, and it also did nothing for boost 1.74+ with EOSIO/fc#176. But unfortunately that fc commit was not backported to 2.0.x

Since the test's behavior is dependent on this line doing nothing, remove the line 😄

For consistency this removal should be applied on all branches once accepted.

("nothing" here doesn't literally mean nothing, but rather that a copy of the reversible DB file does not occur)

Change Type

Select ONE:

• Documentation

• Stability bug fix

• Other

• Other - special case

Testing Changes

Select ANY that apply:

• New Tests

• Existing Tests

• Test Framework

• CI System

• Other

Consensus Changes

• Consensus Changes

API Changes

• API Changes

Documentation Additions

• Documentation Additions

[spoonincode]

Because this line is actually already removed in 2.2, I'm not going to bother with a 2.1 uplift. 2.1 won't break as is (because of the fc fix).