This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Add a unit test for the write order for aliased intrinsic arguments. - #7973
Merged
Merged
Conversation
…y key lower/upper bound.
Contributor
Isn't anything that takes multiple references, like get_resource_limits(), also at risk? We should probably have a test that covers reference types. |
Contributor
Author
Yes. I thought I checked all the intrinsics, but I missed that somehow. |
Contributor
Author
|
I can't find any tests for get_resource_limits or the rest of the privileged_api. |
spoonincode
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This only affects lower/upper bound for secondary keys, as they are the only intrinsics with multiple output parameters. The order depends on the alignment of the arguments.
Consensus Changes
API Changes
Documentation Additions