Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Add a unit test for the write order for aliased intrinsic arguments. - #7973

Merged
swatanabe-b1 merged 4 commits into
developfrom
lowerbound_secondary_alias
Apr 7, 2020
Merged

swatanabe-b1 merged 4 commits into
developfrom
lowerbound_secondary_alias

Conversation

@swatanabe-b1

Copy link
Copy Markdown
Contributor

Change Description

This only affects lower/upper bound for secondary keys, as they are the only intrinsics with multiple output parameters. The order depends on the alignment of the arguments.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@spoonincode

spoonincode commented Sep 23, 2019 •

Copy link
Copy Markdown
Contributor

This only affects lower/upper bound for secondary keys, as they are the only intrinsics with multiple output parameters

Isn't anything that takes multiple references, like get_resource_limits(), also at risk? We should probably have a test that covers reference types.

@swatanabe-b1

Copy link
Copy Markdown
Contributor Author

Isn't anything that takes multiple references, like get_resource_limits(), also at risk?

Yes. I thought I checked all the intrinsics, but I missed that somehow.

@swatanabe-b1

Copy link
Copy Markdown
Contributor Author

I can't find any tests for get_resource_limits or the rest of the privileged_api.

@swatanabe-b1
swatanabe-b1 merged commit b3f6247 into develop Apr 7, 2020
@swatanabe-b1
swatanabe-b1 deleted the lowerbound_secondary_alias branch April 7, 2020 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants