This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Fix for NPM in CI. - #8237
Merged
Merged
Fix for NPM in CI.#8237
Conversation
zreyn
approved these changes
Nov 22, 2019
zreyn
left a comment
zreyn
left a comment
Contributor
There was a problem hiding this comment.
🍻I really, really like these changes.
scottarnette
marked this pull request as ready for review
November 22, 2019 16:02
This reverts commit dd085c9.
heifner
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Replaced definitions for each dependency per distro to one
package.jsonfile.Perform
npm installinscripts/serial-test.shprior to test execution.See:
https://buildkite.com/EOSIO/eosio/builds/18830 | Pinned build.
https://buildkite.com/EOSIO/eosio-build-unpinned/builds/883 | Unpinned build.
Note: SHiP test seems to fail on Mac occasionally. See here and here for examples.
Consensus Changes
API Changes
Documentation Additions