This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
[Develop] Added better sleep pre-execute for Anka commands + boost fix - #8453
Merged
Merged
Conversation
NorseGaud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Problem: A networking init limitation in the anka software forces us to sleep before commands to wait for it to initialize fully. Using an integer for the seconds we need to sleep is not flexible enough.
Solution: Use a while loop with ping (in anka buildkite plugin v0.5.7) to sleep as long as we need to, until the ping gets a response.
Problem 2: Boost refuses to install without SDKROOT set SDKROOT="$(xcrun --sdk macosx --show-sdk-path)". Our CI/CD dep script doesn't set it, so it fails to build the tag.
Solution: Added the necessary SDKROOT env
Consensus Changes
API Changes
Documentation Additions