Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Fix wasm-runtime option parameters - #8657

Merged
lparisc merged 3 commits into
developfrom
dixia-patch-issue-8624
Feb 28, 2020
Merged

lparisc merged 3 commits into
developfrom
dixia-patch-issue-8624

Conversation

@dixia

@dixia dixia commented Feb 18, 2020 •

Copy link
Copy Markdown
Contributor

Change Description

Resolves #8624

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@dixia
dixia requested a review from lparisc February 18, 2020 06:39
@dixia

dixia commented Feb 18, 2020

Copy link
Copy Markdown
Contributor Author

Fix #8624

@heifner heifner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this listed the valid options.

@lparisc

lparisc commented Feb 18, 2020 •

Copy link
Copy Markdown
Contributor

We pull the valid options from the nodeos --help, which also needs further clarification:

  --wasm-runtime runtime                Override default WASM runtime

@dixia The runtime options are: wabt (default), eos-vm, eos-vm-jit. eos-vm-oc-enable is a related option. I would replace with:

  --wasm-runtime eos-vm|eos-vm-jit      Override default WASM runtime (wabt)
  --eos-vm-oc-enable                    Enable optimized compilation

@arhag Please note suggested nodeos --help message for --wasm-runtime.

@dixia

dixia commented Feb 20, 2020

Copy link
Copy Markdown
Contributor Author

hi all, this is to update the out-of-date doc but not to update the code which has actual nodeos --help message

happy to create a separate Issue/PR to update the code as well but that should be done separately

@lparisc lparisc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

  --wasm-runtime eos-vm|eos-vm-jit      Override default WASM runtime (wabt)
  --eos-vm-oc-enable                    Enable optimized compilation

@dixia dixia closed this Feb 25, 2020
@dixia dixia reopened this Feb 25, 2020
@sunshineveg

Copy link
Copy Markdown

Set up a separate PR for the code issue and close the documentation issue.

@lparisc
lparisc self-requested a review February 28, 2020 18:25
@lparisc
lparisc merged commit 02cd4af into develop Feb 28, 2020
@lparisc lparisc changed the title Fix #8624 Fix wasm-runtime option parameters Mar 5, 2020
@lparisc lparisc mentioned this pull request Mar 5, 2020
1 of 3 tasks
@heifner
heifner deleted the dixia-patch-issue-8624 branch March 12, 2020 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants