This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Fix wasm-runtime option parameters - #8657
Merged
Merged
Conversation
Contributor
Author
|
Fix #8624 |
heifner
reviewed
Feb 18, 2020
heifner
left a comment
Contributor
There was a problem hiding this comment.
Would be nice if this listed the valid options.
Contributor
|
We pull the valid options from the @dixia The runtime options are: @arhag Please note suggested |
Contributor
Author
|
hi all, this is to update the out-of-date doc but not to update the code which has actual happy to create a separate Issue/PR to update the code as well but that should be done separately |
lparisc
suggested changes
Feb 25, 2020
lparisc
left a comment
Contributor
There was a problem hiding this comment.
Should be:
--wasm-runtime eos-vm|eos-vm-jit Override default WASM runtime (wabt)
--eos-vm-oc-enable Enable optimized compilation
|
Set up a separate PR for the code issue and close the documentation issue. |
lparisc
self-requested a review
February 28, 2020 18:25
lparisc
approved these changes
Feb 28, 2020
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #8624
Consensus Changes
API Changes
Documentation Additions