This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Add unit test to verify that the description digests of protocol feat… - #8720
Merged
Merged
Conversation
spoonincode
suggested changes
Mar 26, 2020
spoonincode
approved these changes
Mar 26, 2020
spoonincode
left a comment
spoonincode
left a comment
Contributor
There was a problem hiding this comment.
Can't help but feel we're doing this backwards. As in maybe generate the .cpp file from the descriptions.
Contributor
Author
|
I think we do want to hard-code the hash, as it's less prone to inadvertent changes than the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ures are correct.
Change Description
Consensus Changes
API Changes
Documentation Additions