Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Increase get info priority to medium high - 2.0 - #8894

Merged
allenhan2 merged 1 commit into
release/2.0.xfrom
get_info_higer_priority
Mar 30, 2020
Merged

allenhan2 merged 1 commit into
release/2.0.xfrom
get_info_higer_priority

Conversation

@allenhan2

@allenhan2 allenhan2 commented Mar 30, 2020 •

Copy link
Copy Markdown
Contributor

Change Description

related issue #8655
Raise the priority of get_info call for better user response time.

Call tests (30 minutes, 16 threads):
Thread 0, run 8783 times, total(s): 1799.95, avg(ms): 204.94, min(ms): 26.27, max(ms): 20048.91
Thread 1, run 8893 times, total(s): 1800.00, avg(ms): 202.41, min(ms): 22.18, max(ms): 1103.01
Thread 2, run 8904 times, total(s): 1800.00, avg(ms): 202.16, min(ms): 23.07, max(ms): 1096.16
Thread 3, run 8902 times, total(s): 1799.97, avg(ms): 202.20, min(ms): 23.01, max(ms): 1109.02
Thread 4, run 8903 times, total(s): 1799.97, avg(ms): 202.18, min(ms): 23.67, max(ms): 1084.24
Thread 5, run 8898 times, total(s): 1799.98, avg(ms): 202.29, min(ms): 23.92, max(ms): 1100.79
Thread 6, run 8898 times, total(s): 1799.98, avg(ms): 202.29, min(ms): 23.11, max(ms): 1100.67
Thread 7, run 8901 times, total(s): 1799.97, avg(ms): 202.22, min(ms): 23.82, max(ms): 1101.24
Thread 8, run 8901 times, total(s): 1799.97, avg(ms): 202.22, min(ms): 26.60, max(ms): 1104.36
Thread 9, run 8912 times, total(s): 1799.97, avg(ms): 201.97, min(ms): 24.14, max(ms): 1101.28
Thread 10, run 8905 times, total(s): 1799.97, avg(ms): 202.13, min(ms): 26.16, max(ms): 1078.42
Thread 11, run 8912 times, total(s): 1799.97, avg(ms): 201.97, min(ms): 24.14, max(ms): 1100.37
Thread 12, run 8906 times, total(s): 1799.97, avg(ms): 202.11, min(ms): 25.64, max(ms): 1095.99
Thread 13, run 8909 times, total(s): 1799.97, avg(ms): 202.04, min(ms): 22.83, max(ms): 1114.09
Thread 14, run 8902 times, total(s): 1799.97, avg(ms): 202.20, min(ms): 24.95, max(ms): 1095.62
Thread 15, run 8900 times, total(s): 1799.99, avg(ms): 202.25, min(ms): 24.39, max(ms): 1108.46

The max time is 20 sec. it is an improvement, not an ultimate solution yet.

BTW, during get_info calls, NOT seen a significant impact on nodeos syncing latency time,

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@allenhan2
allenhan2 requested a review from heifner March 30, 2020 14:10
@heifner

heifner commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

Note it is theoretically possible to spam a node with get info requests so that it slows down syncing. In testing we were unable to do this in practice. A public API node is expected to provide its own spam protection.

@allenhan2
allenhan2 merged commit 6e8f36f into release/2.0.x Mar 30, 2020
@allenhan2
allenhan2 deleted the get_info_higer_priority branch March 30, 2020 16:03
@heifner heifner changed the title Increase get info priority to medium high Increase get info priority to medium high - 2.0 Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants