This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Increase get info priority to medium high - 2.0 - #8894
Merged
Merged
Conversation
Contributor
|
Note it is theoretically possible to spam a node with |
heifner
approved these changes
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
related issue #8655
Raise the priority of get_info call for better user response time.
Call tests (30 minutes, 16 threads):
Thread 0, run 8783 times, total(s): 1799.95, avg(ms): 204.94, min(ms): 26.27, max(ms): 20048.91
Thread 1, run 8893 times, total(s): 1800.00, avg(ms): 202.41, min(ms): 22.18, max(ms): 1103.01
Thread 2, run 8904 times, total(s): 1800.00, avg(ms): 202.16, min(ms): 23.07, max(ms): 1096.16
Thread 3, run 8902 times, total(s): 1799.97, avg(ms): 202.20, min(ms): 23.01, max(ms): 1109.02
Thread 4, run 8903 times, total(s): 1799.97, avg(ms): 202.18, min(ms): 23.67, max(ms): 1084.24
Thread 5, run 8898 times, total(s): 1799.98, avg(ms): 202.29, min(ms): 23.92, max(ms): 1100.79
Thread 6, run 8898 times, total(s): 1799.98, avg(ms): 202.29, min(ms): 23.11, max(ms): 1100.67
Thread 7, run 8901 times, total(s): 1799.97, avg(ms): 202.22, min(ms): 23.82, max(ms): 1101.24
Thread 8, run 8901 times, total(s): 1799.97, avg(ms): 202.22, min(ms): 26.60, max(ms): 1104.36
Thread 9, run 8912 times, total(s): 1799.97, avg(ms): 201.97, min(ms): 24.14, max(ms): 1101.28
Thread 10, run 8905 times, total(s): 1799.97, avg(ms): 202.13, min(ms): 26.16, max(ms): 1078.42
Thread 11, run 8912 times, total(s): 1799.97, avg(ms): 201.97, min(ms): 24.14, max(ms): 1100.37
Thread 12, run 8906 times, total(s): 1799.97, avg(ms): 202.11, min(ms): 25.64, max(ms): 1095.99
Thread 13, run 8909 times, total(s): 1799.97, avg(ms): 202.04, min(ms): 22.83, max(ms): 1114.09
Thread 14, run 8902 times, total(s): 1799.97, avg(ms): 202.20, min(ms): 24.95, max(ms): 1095.62
Thread 15, run 8900 times, total(s): 1799.99, avg(ms): 202.25, min(ms): 24.39, max(ms): 1108.46
The max time is 20 sec. it is an improvement, not an ultimate solution yet.
BTW, during get_info calls, NOT seen a significant impact on nodeos syncing latency time,
Consensus Changes
API Changes
Documentation Additions