This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Fix SHIP block delay - develop - #8927
Merged
Merged
Conversation
…d is not updated at time of signal
Contributor
|
Is there any possibility of reentering ship (e.g. a socket event) between on_accepted_block and the head being updated? |
kj4ezj
approved these changes
Apr 9, 2020
kj4ezj
left a comment
kj4ezj
left a comment
Contributor
There was a problem hiding this comment.
Automation was able to verify that this pull request eliminated the unexpected 500 millisecond delay we were experiencing in our stack. Great work, and thanks for the incredibly fast turnaround time!!
tbfleming
approved these changes
Apr 10, 2020
This was referenced Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
state_history_pluginsending blocks out on a one block delay (500ms).block_stateofaccepted_blocksignal instead ofchain.head_block_num()as head is not updated at the time of the signal.last_irreversible.block_num&last_irreversible.block_idstill lags by 500ms even with this change. See state_history_plugin LIB notification lags LIB #8951.Consensus Changes
API Changes
Documentation Additions