This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Chainlib support for replacing keys - #8929
Merged
Merged
Conversation
Contributor
|
Related: #7413 |
arhag
suggested changes
Apr 10, 2020
arhag
left a comment
arhag
left a comment
Contributor
There was a problem hiding this comment.
Are there any unit tests we can add to test these new functions?
Contributor
|
Also, merge in the latest |
Contributor
Author
|
@heifner Do you have anyone available who can whip out some tests for this? |
Contributor
|
I believe tests can come in under a diff PR so you can have access to this quickly. @allenhan2 Can you create some tests for this? |
arhag
approved these changes
Apr 10, 2020
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This adds minimal support to chainlib for replacing keys. The initial use case is in
eosio-tester, which exposes these new functions. Unlike prior PRs, this PR:Consensus Changes
API Changes
Documentation Additions