Repository navigation
Remove mongo_db_plugin - #9014
Conversation
| @@ -1,153 +0,0 @@ | |||
| [[warning | Deprecation Notice]] | |||
There was a problem hiding this comment.
@lparisc does removing this file cause any problems?
There was a problem hiding this comment.
It's fine as long as all references to the file are also removed, which seems to be the case.
kj4ezj
left a comment
kj4ezj
left a comment
There was a problem hiding this comment.
Still see a couple mongo references on your branch:
$ git log -1
commit d97ac7312738199f8fc08a7444328b1362d98a6b (HEAD -> remove-mongodb-dev, origin/remove-mongodb-dev)
Merge: 078cca84f 4bdc44f23
Author: Kevin Heifner <heifnerk@objectcomputing.com>
Date: Mon Apr 27 17:33:37 2020 -0500
Merge remote-tracking branch 'origin/develop' into remove-mongodb-dev
$ grep -rni mongo --exclude-dir .git
plugins/COMMUNITY.md:18:| Mongo History API | https://github.com/CryptoLions/EOS-mongo-history-API |
tests/CMakeLists.txt:175: set(ctest_exclude_tests 'nodeos_run_remote_test|nodeos_run_test-mongodb|distributed-transactions-remote-test|restart-scenarios-test_replay')
libraries/fc/include/fc/crypto/webauthn_json/test/unittest/encodingstest.cpp:73: 0x1800, 0x18AF, // MongolianThe second result referring to nodeos_run_test-mongodb doesn't seem right. I would expect that test and all references to it to be gone. The first result doesn't make sense to me, either, really.
|
|
||
|
|
||
| **First**, v1.8 changes the structure of transaction traces, even prior to the activation of any protocol features. Clients consuming transaction and action traces made available through [`history_plugin`](../03_plugins/history_plugin/index.md), [`mongo_db_plugin`](../03_plugins/mongo_db_plugin/index.md), or [`state_history_plugin`](../03_plugins/state_history_plugin/index.md) should be aware of the changes made to the trace structure (see details at [#7044](https://github.com/EOSIO/eos/pull/7044) and [#7108](https://github.com/EOSIO/eos/pull/7108)). Clients consuming the trace output of the `push_transaction` RPC from the chain API should not need to do anything since the output of that RPC should be backwards compatible. However, they are encouraged to replace usage of `push_transaction` with the new RPC [`send_transaction`](https://developers.eos.io/eosio-nodeos/reference#send_transaction) which uses the new flat structure to store the action traces. | ||
| **First**, v1.8 changes the structure of transaction traces, even prior to the activation of any protocol features. Clients consuming transaction and action traces made available through [`history_plugin`](../03_plugins/history_plugin/index.md) or [`state_history_plugin`](../03_plugins/state_history_plugin/index.md) should be aware of the changes made to the trace structure (see details at [#7044](https://github.com/EOSIO/eos/pull/7044) and [#7108](https://github.com/EOSIO/eos/pull/7108)). Clients consuming the trace output of the `push_transaction` RPC from the chain API should not need to do anything since the output of that RPC should be backwards compatible. However, they are encouraged to replace usage of `push_transaction` with the new RPC [`send_transaction`](https://developers.eos.io/eosio-nodeos/reference#send_transaction) which uses the new flat structure to store the action traces. |
There was a problem hiding this comment.
Not sure it's a good idea to remove the mongo_db_plugin reference here (definitely remove the link as it will be broken, but not the reference altogether) since this applies to the 1.8 upgrade guide which included the deprecated yet not removed mongo_db_plugin. I guess we shouldn't rewrite history.
|
About time fellas! 👏👏👏👏👏 |
|
If desired, we can also test this PR's changes to the build scripts with this pipeline. |
Removed. |
|
Kicked off a LRT: https://buildkite.com/EOSIO/eosio-lrt/builds/3415 |
lparisc
added
the
documentation
Change Description
mongo_db_pluginConsensus Changes
API Changes
Documentation Additions
Documentation Additions
mongo_db_pluginstatus changed from deprecated to removed.