This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
move minimum boost from 1.67->1.70; gcc 7->8 - #9041
Merged
Merged
Conversation
heifner
reviewed
May 5, 2020
| # Most boost deps get implictly picked up via fc, as just about everything links to fc. In addition we pick up | ||
| # the pthread dependency through fc. | ||
| find_package(Boost 1.67 REQUIRED COMPONENTS program_options unit_test_framework) | ||
| find_package(Boost 1.70 REQUIRED COMPONENTS program_options unit_test_framework) |
Contributor
There was a problem hiding this comment.
What about EosioTester.cmake.in & EosioTesterBuild.cmake.in
Contributor
Author
There was a problem hiding this comment.
Yeah, I guess those should be "fixed", though I was probably subconsciously ignoring them because #9042. But I'm not sure how eagerly we can take that.
heifner
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Accepted fallout from #9018
Consensus Changes
API Changes
Documentation Additions