This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
make ship WA key serialization match expected serialization - #9088
Merged
Merged
Conversation
spoonincode
marked this pull request as ready for review
May 14, 2020 15:50
tbfleming
approved these changes
May 14, 2020
3 tasks
tbfleming
added a commit
to VaultaFoundation/mandel
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
SHIP was serializing webauthn keys in authority structures in a way that did not match expected typical serialization of webauthn keys. See #9087
This change correcting this will break users who may have figured out this serialization quirk before.
Consensus Changes
API Changes
Documentation Additions