This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
split transaction logging - #9239
Merged
Merged
Conversation
heifner
reviewed
Jun 23, 2020
heifner
reviewed
Jun 24, 2020
heifner
reviewed
Jun 24, 2020
brianjohnson5972
suggested changes
Jun 25, 2020
| fc::optional<transaction_id_type> trx_id; | ||
| fc::raw::unpack( ds, trx_id ); | ||
| if( trx_id ) { | ||
| if (trx_in_progress_sz > def_max_trx_in_progress_size) { |
Contributor
There was a problem hiding this comment.
needs the exact same block of code before line 2649, except you will replace *trx_id with ptr->id(). This will make sure that we check the max trx when the optional trx_id is not present. This would be similar to the trx_message_v0_which case, where we have to read in the complete transaction to be able to calculate the transaction's id.
| snprintf(reason, 72, "Dropping trx, too many trx in progress %lu bytes", trx_in_progress_sz); | ||
| my_impl->producer_plug->log_failed_transaction(*trx_id, reason); | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
also, at line 2646, change EOS_ASSERT(...) to:
if (trx_id && ptr && *trx_id != ptr->id()) {
...->log_failed_trasaction(ptr->id(), "... Provided trx_id does not ..."
EOS_ASSERT(false,...)
}
}
brianjohnson5972
approved these changes
Jun 25, 2020
heifner
reviewed
Jun 25, 2020
|
|
||
| if (ptr && trx_id && *trx_id != ptr->id()) { | ||
| my_impl->producer_plug->log_failed_transaction(*trx_id, "Provided trx_id does not match provided packed_transaction"); | ||
| EOS_ASSERT(true, transaction_id_type_exception, |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This PR splits the transaction_tracing logger into transaction_success_tracing and transaction_failure_tracing loggers; in addition, it adds logging statement for failed signature condition.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
transaction_tracinglogger is removedThe following two loggers are added
transaction_success_tracing- detailed log that emits successful verdicts from relay nodes on the P2P network.transaction_failure_tracing- detailed log that emits failed verdicts from relay nodes on the P2P network.