Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

rpc kv access implement get_kv_table_rows - #9460

Merged
kimjh2005 merged 9 commits into
developfrom
get_kv_table_rows
Sep 2, 2020
Merged

kimjh2005 merged 9 commits into
developfrom
get_kv_table_rows

Conversation

@kimjh2005

@kimjh2005 kimjh2005 commented Sep 1, 2020 •

Copy link
Copy Markdown
Contributor

Change Description

Implemented get_kv_table_rows equivalent to get_table_rows.

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
Comment thread plugins/chain_plugin/chain_plugin.cpp Resolved
fc::variant row_var;
if( p.json ) {
auto time_left = end_time - cur_time;
row_var = abis.binary_to_variant( p.table.to_string(), row_value, abi_serializer::create_yield_function( time_left ), shorten_abi_errors );

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try-catch here as well

@kimjh2005
kimjh2005 merged commit 38e09bc into develop Sep 2, 2020
@kimjh2005 kimjh2005 mentioned this pull request Sep 3, 2020
7 tasks
@kj4ezj
kj4ezj deleted the get_kv_table_rows branch July 19, 2021 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants