This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
restore dropped commit from fc resubmod: GMP options - #9596
Merged
Merged
Conversation
swatanabe-b1
approved these changes
Oct 28, 2020
Platinumwrist
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This PR restores the previously approved and merged #9054. That PR was merged while fc was desubmodularized, but the resubmodularization of fc dropped this change.
EPE-372 covers the more general case that someone needs to investigate this resubmodularization and ensure other changes were not dropped. I did not do that in restoration of this commit.
Needs EOSIO/fc#170
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions