This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
Fix snapshot test_compatible_versions failure and reenable it - release/2.1.x - #9812
Merged
Merged
Conversation
brianjohnson5972
changed the title
brianjohnson5972
suggested changes
Dec 18, 2020
brianjohnson5972
left a comment
brianjohnson5972
left a comment
Contributor
There was a problem hiding this comment.
Actually, I'm approving this, but marking it not approved till we decide what is going into RC2.
brianjohnson5972
approved these changes
Dec 18, 2020
2 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
https://blockone.atlassian.net/browse/EPE-454
snapshot test_compatible_versions was broken and had to be disabled in Rel. 2.1 RC1.
The root cause is found to be special handing for v4 snapshot was missing.
This PR fixes that problem and reenable the test.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Reenable
test_compatible_versionsin unittests/snapshot_tests.cppConsensus Changes
API Changes
Documentation Additions