Skip to content

bfdd: BFD Admin-Down State Management Improvements - #20151

Merged
riw777 merged 2 commits into
FRRouting:masterfrom
sougatahitcs:bfd-admin-down-state-handling-improvements
Feb 24, 2026
Merged

bfdd: BFD Admin-Down State Management Improvements#20151
riw777 merged 2 commits into
FRRouting:masterfrom
sougatahitcs:bfd-admin-down-state-handling-improvements

Conversation

@sougatahitcs

Copy link
Copy Markdown
Contributor

Currently, all BFD clients such as BGP, OSPF, and PIM experience a session flap when a BFD AdminDown event occurs. This change ensures that the client sessions do not flap on an AdminDown event and instead continue to remain established.

@frrbot frrbot Bot added the bfd label Nov 29, 2025
@sougatahitcs
sougatahitcs force-pushed the bfd-admin-down-state-handling-improvements branch 2 times, most recently from ba9b9bb to 43ad22b Compare November 30, 2025 17:43
@sougatahitcs
sougatahitcs marked this pull request as draft December 7, 2025 16:17
@sougatahitcs
sougatahitcs force-pushed the bfd-admin-down-state-handling-improvements branch from 43ad22b to 177073e Compare December 19, 2025 18:31
@sougatahitcs

Copy link
Copy Markdown
Contributor Author

ci:rerun

@sougatahitcs
sougatahitcs marked this pull request as ready for review December 23, 2025 04:00
@sougatahitcs

Copy link
Copy Markdown
Contributor Author

Hi @donaldsharp Can you please review this MR ?

@donaldsharp

Copy link
Copy Markdown
Member

LGTM

Comment thread ospf6d/ospf6_bfd.c Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/r1/frr.conf
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
Comment thread tests/topotests/bfd_admin_down_no_impact/test_bfd_admin_down_no_impact.py Outdated
@frrbot frrbot Bot added the ospfv3 label Feb 18, 2026
@sougatahitcs
sougatahitcs force-pushed the bfd-admin-down-state-handling-improvements branch 2 times, most recently from 727f617 to c87124c Compare February 19, 2026 04:47
Currently, all BFD clients such as BGP, OSPF, and PIM experience a session flap when a BFD AdminDown event occurs.
This change ensures that the client sessions do not flap on an AdminDown event and instead continue to remain established.

Signed-off-by: Sougata Barik <sougatahitcs@gmail.com>
zlog_debug is not present today in ospfv3 , adding the support

Signed-off-by: Sougata Barik <sougatahitcs@gmail.com>
@sougatahitcs
sougatahitcs force-pushed the bfd-admin-down-state-handling-improvements branch from c87124c to 83d592c Compare February 19, 2026 04:49
@sougatahitcs

Copy link
Copy Markdown
Contributor Author

CI:rerun

@sougatahitcs

Copy link
Copy Markdown
Contributor Author

@rzalamena I have addressed your review comments. Please check.

@sougatahitcs
sougatahitcs force-pushed the bfd-admin-down-state-handling-improvements branch from 2b25564 to 83d592c Compare February 24, 2026 12:15

@riw777 riw777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
riw777 merged commit 45bd200 into FRRouting:master Feb 24, 2026
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants