yang: Correct pyang errors in frr-nexthop.yang - #20694
Merged
Merged
Conversation
Correct pyang errors in frr-nexthop.yang Signed-off-by: y-bharath14 <y.bharath@samsung.com>
Greptile OverviewGreptile SummaryThis PR addresses all 11 RFC 8407 compliance errors in
All descriptions are technically accurate, clear, and follow YANG conventions. No functional changes to the schema were made - this is purely metadata enhancement for RFC compliance. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Pyang as Pyang Validator
participant YANG as frr-nexthop.yang
participant RFC as RFC 8407 Compliance
Dev->>Pyang: Run pyang validation
Pyang->>YANG: Check RFC 8407 compliance
YANG-->>Pyang: 11 errors found
Pyang-->>Dev: Report errors (missing descriptions/references)
Note over Dev,YANG: Fix Process
Dev->>YANG: Add reference to revision (line 64-65)
Dev->>YANG: Add description to typedefs (2 locations)
Dev->>YANG: Add description to groupings (7 locations)
Dev->>YANG: Add description to seg leaf (line 351-352)
Dev->>YANG: Add description to augment (line 374-375)
Dev->>Pyang: Re-run validation
Pyang->>YANG: Check RFC 8407 compliance
YANG-->>Pyang: All checks pass
Pyang-->>RFC: YANG module now compliant
Pyang-->>Dev: Validation successful (0 errors)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct pyang errors in frr-nexthop.yang
frr-nexthop.yang:60: error: RFC 8407: 4.8: statement "revision" must have a "reference" substatement
frr-nexthop.yang:65: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-nexthop.yang:145: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-nexthop.yang:155: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:218: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:255: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:268: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:280: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:296: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:330: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-nexthop.yang:352: error: RFC 8407: 4.14: statement "augment" must have a "description" substatement