Skip to content

yang: Correct pyang errors in frr-nexthop.yang - #20694

Merged
donaldsharp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V7
Feb 4, 2026
Merged

yang: Correct pyang errors in frr-nexthop.yang#20694
donaldsharp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V7

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

Correct pyang errors in frr-nexthop.yang

frr-nexthop.yang:60: error: RFC 8407: 4.8: statement "revision" must have a "reference" substatement
frr-nexthop.yang:65: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-nexthop.yang:145: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-nexthop.yang:155: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:218: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:255: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:268: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:280: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:296: error: RFC 8407: 4.14: statement "grouping" must have a "description" substatement
frr-nexthop.yang:330: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-nexthop.yang:352: error: RFC 8407: 4.14: statement "augment" must have a "description" substatement

Correct pyang errors in frr-nexthop.yang

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@frrbot frrbot Bot added the yang label Feb 4, 2026
@greptile-apps

greptile-apps Bot commented Feb 4, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

This PR addresses all 11 RFC 8407 compliance errors in frr-nexthop.yang identified by pyang validation. The changes are purely documentation additions that make the YANG module compliant with IETF best practices:

  • Added reference substatement to the revision (line 64-65)
  • Added description substatements to 2 typedefs (optional-ip-address, nexthop-group-ref)
  • Added description substatements to 7 groupings (all nexthop-related groupings)
  • Added description substatement to the seg leaf in the SRv6 segs stack
  • Added description substatement to the augment statement

All descriptions are technically accurate, clear, and follow YANG conventions. No functional changes to the schema were made - this is purely metadata enhancement for RFC compliance.

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • All changes are purely additive documentation (descriptions and references) required for RFC 8407 compliance. No functional code changes, no schema modifications, and all 11 pyang errors are correctly resolved.
  • No files require special attention

Important Files Changed

Filename Overview
yang/frr-nexthop.yang Added required RFC 8407 compliant descriptions and references to fix all 11 pyang validation errors

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Pyang as Pyang Validator
    participant YANG as frr-nexthop.yang
    participant RFC as RFC 8407 Compliance

    Dev->>Pyang: Run pyang validation
    Pyang->>YANG: Check RFC 8407 compliance
    YANG-->>Pyang: 11 errors found
    Pyang-->>Dev: Report errors (missing descriptions/references)
    
    Note over Dev,YANG: Fix Process
    Dev->>YANG: Add reference to revision (line 64-65)
    Dev->>YANG: Add description to typedefs (2 locations)
    Dev->>YANG: Add description to groupings (7 locations)
    Dev->>YANG: Add description to seg leaf (line 351-352)
    Dev->>YANG: Add description to augment (line 374-375)
    
    Dev->>Pyang: Re-run validation
    Pyang->>YANG: Check RFC 8407 compliance
    YANG-->>Pyang: All checks pass
    Pyang-->>RFC: YANG module now compliant
    Pyang-->>Dev: Validation successful (0 errors)
Loading

@github-actions github-actions Bot added the size/S label Feb 4, 2026
@donaldsharp
donaldsharp merged commit 9750969 into FRRouting:master Feb 4, 2026
22 of 23 checks passed
@github-actions github-actions Bot added the master label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants