Skip to content

yang: Fix pyang errors in frr-bgp-filter.yang - #20746

Merged
Jafaral merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V8
Feb 10, 2026
Merged

yang: Fix pyang errors in frr-bgp-filter.yang#20746
Jafaral merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V8

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

Fix pyang errors in frr-bgp-filter.yang

frr-bgp-filter.yang:22: error: RFC 8407: 4.8: statement "revision" must have a "reference" substatement
frr-bgp-filter.yang:74: error: RFC 8407: 4.14: statement "augment" must have a "description" substatement
frr-bgp-filter.yang:79: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:87: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:91: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:141: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:149: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:153: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:215: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:223: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:227: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:271: error: RFC 8407: 4.14: statement "leaf-list" must have a "description" substatement
frr-bgp-filter.yang:279: error: RFC 8407: 4.14: statement "leaf-list" must have a "description" substatement
frr-bgp-filter.yang:313: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement
frr-bgp-filter.yang:317: error: RFC 8407: 4.14: statement "leaf" must have a "description" substatement

Fix pyang errors in frr-bgp-filter.yang

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@greptile-apps

greptile-apps Bot commented Feb 10, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

This PR updates yang/frr-bgp-filter.yang to satisfy RFC 8407 style requirements enforced by pyang by adding:

  • a reference substatement under the module revision
  • description substatements for the augment and a set of leaf / leaf-list nodes that previously lacked descriptions

These changes are documentation/metadata-only within the YANG model and do not alter list keys, types, or augment paths, so the effective schema should remain the same while removing the reported pyang errors.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are limited to adding missing YANG description/reference substatements to satisfy RFC 8407 checks; no structural schema changes (paths/keys/types) were introduced in the diff reviewed.
  • No files require special attention.

Important Files Changed

Filename Overview
yang/frr-bgp-filter.yang Adds missing RFC 8407-required substatements (reference on revision; description on augment and several leaves/leaf-lists) without changing the schema structure.

Sequence Diagram

sequenceDiagram
    participant Author as PR Author
    participant YANG as yang/frr-bgp-filter.yang
    participant Pyang as pyang (RFC 8407 checks)

    Author->>YANG: Add missing reference/description substatements
    Pyang->>YANG: Validate revision has reference
    Pyang->>YANG: Validate augment/leaf/leaf-list have description
    Pyang-->>Author: Errors cleared (RFC 8407 compliance)
Loading

@Jafaral

Jafaral commented Feb 10, 2026

Copy link
Copy Markdown
Member

@Mergifyio backport dev/10.6

@mergify

mergify Bot commented Feb 10, 2026

Copy link
Copy Markdown

backport dev/10.6

βœ… Backports have been created

Details

@Jafaral
Jafaral merged commit 0901c2a into FRRouting:master Feb 10, 2026
23 checks passed
donaldsharp added a commit that referenced this pull request Feb 10, 2026
yang: Fix pyang errors in frr-bgp-filter.yang (backport #20746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants