tests: Add additional wait tim to test_bgp_gr_functionality_topo2-3.py - #20788
Merged
mjstapp merged 1 commit intoFeb 13, 2026
Merged
Conversation
This test is testing out GR, but is expecting routes to have been received from several routers down the line by the time the EOR has been received on the router under test. This is not a guaranteed order of events. So give the test a bit more time to see if things stabilize. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Greptile OverviewGreptile SummaryThis PR increases the retry timeout for BGP RIB route verification in a graceful restart test scenario. The change specifically targets verification of routes from r2 reaching r6 via r1 after graceful restart, extending the wait time from the default 30 seconds to 60 seconds. The modification addresses a race condition where:
The fix properly uses the Confidence Score: 5/5
Important Files Changed
|
mjstapp
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is testing out GR, but is expecting routes to have been received from several routers down the line by the time the EOR has been received on the router under test. This is not a guaranteed order of events. So give the test a bit more time to see if things stabilize.